Summary: | emerge modifies owner, group and permissions of /dev/null | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Harald Becker <hb-xxl> |
Component: | Unclassified | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | InVCS |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 683434 |
Description
Harald Becker
2019-04-24 07:21:29 UTC
While your finding looks valid and should be fixed, another question that comes to my mind is if there's really no other possibility to disable logging of portage except of symlinking the log files to /dev/null. If not, this should be addresses and perhaps fixed as well. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/portage.git/commit/?id=71f6a23c497980f4424fca51ac3e2864608ab08d commit 71f6a23c497980f4424fca51ac3e2864608ab08d Author: Zac Medico <zmedico@gentoo.org> AuthorDate: 2019-04-24 18:50:42 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2019-04-24 18:52:57 +0000 emergelog: handle /dev/null symlink (bug 684232) If the log path is a symlink to /dev/null, os.path.isfile returns False, so use os.path.exists in order to avoid chown/chmod in this case. Reported-by: Harald Becker <hb-xxl@web.de> Bug: https://bugs.gentoo.org/684232 Signed-off-by: Zac Medico <zmedico@gentoo.org> lib/_emerge/emergelog.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (In reply to Lars Wendler (Polynomial-C) from comment #1) > While your finding looks valid and should be fixed, another question that > comes to my mind is if there's really no other possibility to disable > logging of portage except of symlinking the log files to /dev/null. > If not, this should be addresses and perhaps fixed as well. Maybe we could use an empty EMERGE_LOG_DIR setting for that. (In reply to Lars Wendler (Polynomial-C) from comment #1) > While your finding looks valid and should be fixed, another question that > comes to my mind is if there's really no other possibility to disable > logging of portage except of symlinking the log files to /dev/null. > If not, this should be addresses and perhaps fixed as well. I won't say I'm familiar with Portage and the emerge system, but I'm no Unix/Linux novice and able to read manpages. Looking through 'emerge(1)', 'make.conf(5)' and 'portage(5)' manpages, I could not find any hint how to disable 'emerge.log' and/or 'emerge-fetch.log'. If there is such a feature it's hidden anywhere very deep in the docs or the source. I'd like to see two more options for 'make.conf': EMERGE_LOG=<path_to_logfile> EMERGE_FETCH_LOG=<path_to_logfile> When unset they shall revert to current values, when set to an empty string they shall behave like a setting to /dev/null. (In reply to Zac Medico from comment #3) > (In reply to Lars Wendler (Polynomial-C) from comment #1) > > While your finding looks valid and should be fixed, another question that > > comes to my mind is if there's really no other possibility to disable > > logging of portage except of symlinking the log files to /dev/null. > > If not, this should be addresses and perhaps fixed as well. > > Maybe we could use an empty EMERGE_LOG_DIR setting for that. Why specifying a log directory and not the full name of the log file, which also allows changes of the log file name. If an EMERGE_LOG specifies an existing directory, the default 'emerge.log' may be appended. To: Larry the Git Cow from comment #2 Thanks to your very quick response. I'm going to look into the second permission change that occurred yesterday, soon. (In reply to Harald Becker from comment #5) > (In reply to Zac Medico from comment #3) > > (In reply to Lars Wendler (Polynomial-C) from comment #1) > > > While your finding looks valid and should be fixed, another question that > > > comes to my mind is if there's really no other possibility to disable > > > logging of portage except of symlinking the log files to /dev/null. > > > If not, this should be addresses and perhaps fixed as well. > > > > Maybe we could use an empty EMERGE_LOG_DIR setting for that. > Why specifying a log directory and not the full name of the log file, which > also allows changes of the log file name. If an EMERGE_LOG specifies an > existing directory, the default 'emerge.log' may be appended. Sure we can add separate variables. EMERGE_LOG_DIR is just the variable that's currently supported but we can make the new variables take precedence. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=eca0a8648ae7cee5c10081224432e15bc31f05ba commit eca0a8648ae7cee5c10081224432e15bc31f05ba Author: Zac Medico <zmedico@gentoo.org> AuthorDate: 2019-04-26 02:53:25 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2019-04-26 03:00:38 +0000 sys-apps/portage: version bump to 2.3.65 #478544 fix duplicate repo warning triggered by PORTDIR #553224 emerge --info per-package FEATURES #684232 don't set permissions on /dev/null emerge.log symlink Bug: https://bugs.gentoo.org/683434 Bug: https://bugs.gentoo.org/478544 Bug: https://bugs.gentoo.org/553224 Bug: https://bugs.gentoo.org/684232 Package-Manager: Portage-2.3.65, Repoman-2.3.12 Signed-off-by: Zac Medico <zmedico@gentoo.org> sys-apps/portage/Manifest | 1 + sys-apps/portage/portage-2.3.65.ebuild | 259 +++++++++++++++++++++++++++++++++ 2 files changed, 260 insertions(+) |