Bug 682218 – sys-devel/gcc: please backport "Disable jump tables when retpolines are used"

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Thomas Deutschmann (RETIRED) 2019-04-01 11:05:00 UTC]

Please backport

> Disable jump tables when retpolines are used


> Author: marxin
> Date: Mon Mar 11 09:38:06 2019
> New Revision: 269572
> 
> URL: https://gcc.gnu.org/viewcvs?rev=269572&root=gcc&view=rev
> Log:
> Backport r269492
> 
> 2019-03-11  Martin Liska  <[e-mail]>
> 
> 	Backport from mainline
> 	2019-03-08  Martin Liska  <[e-mail]>
> 
> 	PR target/86952
> 	* config/i386/i386.c (ix86_option_override_internal): Disable
> 	jump tables when retpolines are used.
> 2019-03-11  Martin Liska  <[e-mail]>
> 
> 	Backport from mainline
> 	2019-03-08  Martin Liska  <[e-mail]>
> 
> 	PR target/86952
> 	* gcc.target/i386/indirect-thunk-7.c: Use jump tables to match
> 	scanned pattern.
> 	* gcc.target/i386/indirect-thunk-inline-7.c: Likewise.
> 
> Modified:
>     branches/gcc-8-branch/gcc/ChangeLog
>     branches/gcc-8-branch/gcc/config/i386/i386.c
>     branches/gcc-8-branch/gcc/testsuite/ChangeLog
>     branches/gcc-8-branch/gcc/testsuite/gcc.target/i386/indirect-thunk-7.c
>     branches/gcc-8-branch/gcc/testsuite/gcc.target/i386/indirect-thunk-inline-7.c


See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ce02ef06fcf7

[Comment 1 Larry the Git Cow 2019-04-04 07:03:14 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gcc-patches.git/commit/?id=8f536c47fddf4a9fe15b969b888f4dbd22c1f82a

commit 8f536c47fddf4a9fe15b969b888f4dbd22c1f82a
Author:     Sergei Trofimovich <[e-mail]>
AuthorDate: 2019-04-04 07:00:23 +0000
Commit:     Sergei Trofimovich <[e-mail]>
CommitDate: 2019-04-04 07:00:23 +0000

    8.3.0: backport retpoline/jumptable optimization on i386
    
    Reported-by: Thomas Deutschmann
    Bug: https://gcc.gnu.org/PR86952
    Bug: https://bugs.gentoo.org/682218
    Signed-off-by: Sergei Trofimovich <[e-mail]>

 .../28_all_i386_retpoline-and-jumptable.patch      | 64 ++++++++++++++++++++++
 8.3.0/gentoo/README.history                        |  1 +
 2 files changed, 65 insertions(+)

[Comment 2 Sergei Trofimovich (RETIRED) 2019-04-04 07:04:06 UTC]

Queued for next gcc-83.0 patchset. Will cut it this weekend if nothing else pops up.

[Comment 3 Larry the Git Cow 2019-04-06 12:45:16 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gcc-patches.git/commit/?id=c8e228e9ad5ff6e81cf0fb3a6c0f7fb2929519bf

commit c8e228e9ad5ff6e81cf0fb3a6c0f7fb2929519bf
Author:     Sergei Trofimovich <[e-mail]>
AuthorDate: 2019-04-06 10:44:29 +0000
Commit:     Sergei Trofimovich <[e-mail]>
CommitDate: 2019-04-06 10:44:29 +0000

    8.3.0: cut 1.1 patchset
    
    Three new patches:
    - 26_all_overridable_native.patch
    - 27_all_flto-make-all.patch
    - 28_all_i386_retpoline-and-jumptable.patch
    
    Bug: https://bugs.gentoo.org/679738
    Bug: https://bugs.gentoo.org/682018
    Bug: https://bugs.gentoo.org/682218
    Signed-off-by: Sergei Trofimovich <[e-mail]>

 8.3.0/gentoo/README.history | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[Comment 4 Larry the Git Cow 2019-04-06 12:49:58 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ce95a47723f26ab8a687c3dffeea80aea71bfd87

commit ce95a47723f26ab8a687c3dffeea80aea71bfd87
Author:     Sergei Trofimovich <[e-mail]>
AuthorDate: 2019-04-06 12:49:11 +0000
Commit:     Sergei Trofimovich <[e-mail]>
CommitDate: 2019-04-06 12:49:50 +0000

    sys-devel/gcc: cut 1.1 patchset for 8.3.0
    
    Three new patches:
    - 26_all_overridable_native.patch
    - 27_all_flto-make-all.patch
    - 28_all_i386_retpoline-and-jumptable.patch
    
    This is also the first EAPI=6 gcc ebuild.
    
    Closes: https://bugs.gentoo.org/679738
    Closes: https://bugs.gentoo.org/682018
    Closes: https://bugs.gentoo.org/682218
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Sergei Trofimovich <[e-mail]>

 sys-devel/gcc/Manifest            |  1 +
 sys-devel/gcc/gcc-8.3.0-r1.ebuild | 19 +++++++++++++++++++
 2 files changed, 20 insertions(+)