| Summary: | net-libs/grpc: <grpc++/grpc++.h> missing (?) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Michał Górny <mgorny> |
| Component: | Current packages | Assignee: | Jason Zaman <perfinion> |
| Status: | RESOLVED UPSTREAM | ||
| Severity: | normal | CC: | gyakovlev |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://github.com/draios/sysdig/pull/1349 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
Hm, how long ago is sysdig from? https://github.com/grpc/grpc/pull/14210 https://github.com/grpc/grpc/commit/0e00c430827e81d61e1e7164ef04ca21ccbfaa77 says <grpc++/grpc++h> was deprecated and moved to <grpcpp/grpcpp.h> since v1.10.0 (a bit over a year ago). Looks like they should already be added tho: https://github.com/grpc/grpc/blob/206592ce9c104e95cf699e81d20c3cadbf1f4d1a/Makefile#L5287 I'm definitely not opposed to adding the other stub files in grpc++/ but the other option is to patch sysdig since nothing else appears to have complained so far. Ok, thanks. I've submitted a patch for sysdig already. It's a fresh release but I see they're normally building against bundled 1.8.1... Is this still an issue? (In reply to kunda from comment #3) > Is this still an issue? Upstream has merged my PR but there hasn't been a release with it yet. I see no patches in tree anymore, looks like this can be closed? checked upstream, both versions we have in tree contain fixes. closing. |
dev-util/sysdig started requiring net-libs/grpc. However, it fails to build (after fixing all the other upstream silliness) with the following error: [3/9] Building CXX object userspace/libsinsp/CMakeFiles/sinsp.dir/cri.cpp.o FAILED: userspace/libsinsp/CMakeFiles/sinsp.dir/cri.cpp.o /usr/bin/c++ -DHAS_CAPTURE -DK8S_DISABLE_THREAD -DPLATFORM_NAME=\"Linux\" -I../userspace/libsinsp/. -I../userspace/libsinsp/../../common -I../userspace/libsinsp/../libscap -I/usr/include/jsoncpp -I/usr/include/luajit-2.0 -I/usr/include/tbb -Iuserspace/libsinsp -Wall -ggdb -std=c++0x -O3 -fno-strict-aliasing -DNDEBUG -MD -MT userspace/libsinsp/CMakeFiles/sinsp.dir/cri.cpp.o -MF userspace/libsinsp/CMakeFiles/sinsp.dir/cri.cpp.o.d -o userspace/libsinsp/CMakeFiles/sinsp.dir/cri.cpp.o -c ../userspace/libsinsp/cri.cpp ../userspace/libsinsp/cri.cpp:23:10: fatal error: grpc++/grpc++.h: No such file or directory #include <grpc++/grpc++.h> ^~~~~~~~~~~~~~~~~ It seems that we're installing grpc++/impl alongside grpcpp/impl but not other files from grpcpp tree. I think we should either settle on not installing grpc++ tree at all, or install it completely usable.