Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 681218

Summary: app-emulation/wine-staging USE=faudio should exclude xaudio2_revert patches
Product: Gentoo Linux Reporter: Dmitry Derevyanko <nrndda>
Component: Current packagesAssignee: Wine Maintainers <wine>
Status: RESOLVED FIXED    
Severity: normal Keywords: PATCH
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Revert-xaudio2_revert.patch

Description Dmitry Derevyanko 2019-03-22 02:35:12 UTC
Staging patches include xaudio2 revert by default for now. For USE faudio this patches need revert.

Reproducible: Always
Comment 1 Dmitry Derevyanko 2019-03-22 02:36:02 UTC
Created attachment 570286 [details, diff]
Revert-xaudio2_revert.patch
Comment 2 Maxime Lombard 2019-03-22 17:38:59 UTC
Right, and i suggest to set FAudio USE flag enabled by default. Because when Staging will delete "xaudio revert" patches when all Linux OS will have FAudio package, the user will have no sound.
Comment 3 Nick Sarnie gentoo-dev 2019-03-22 22:22:21 UTC
@Dmitry, please give me your signed-off-by for the patch
Comment 4 Dmitry Derevyanko 2019-03-22 23:01:59 UTC
(In reply to Nick Sarnie from comment #3)
> @Dmitry, please give me your signed-off-by for the patch

Signed-off-by: Dmitry Derevyanko <nrndda@gmail.com>
Comment 5 Larry the Git Cow gentoo-dev 2019-03-23 20:37:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/wine.git/commit/?id=8af67d1e0f7d0282cd106e5be06699f9960fc12d

commit 8af67d1e0f7d0282cd106e5be06699f9960fc12d
Author:     Nick Sarnie <sarnex@gentoo.org>
AuthorDate: 2019-03-23 20:36:41 +0000
Commit:     Nick Sarnie <sarnex@gentoo.org>
CommitDate: 2019-03-23 20:37:13 +0000

    app-emulation/wine-staging: Faudio updates
    
    Patch exlucision part from Dmitry:
    Signed-off-by: Dmitry Derevyanko <nrndda@gmail.com>
    Closes: https://bugs.gentoo.org/681218
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Nick Sarnie <sarnex@gentoo.org>

 .../wine-staging/wine-staging-4.4-r1.ebuild        | 617 +++++++++++++++++++++
 .../wine-staging/wine-staging-9999.ebuild          |   3 +-
 2 files changed, 619 insertions(+), 1 deletion(-)