Summary: | dev-qt/qtwebkit-5.212.0_pre20180120: build failure: Source/WebCore/bindings/js/JSDOMConstructor.h: error: invalid conversion from ‘JSC::EncodedJSValue (*)(JSC::ExecState*)’ | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Thomas Deutschmann (RETIRED) <whissi> |
Component: | Current packages | Assignee: | Qt Bug Alias <qt> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
build.log
qtwebkit-5.212.0_pre20180120-JSC_HOST_CALL.patch |
Description
Thomas Deutschmann (RETIRED)
![]() Created attachment 569746 [details]
build.log
ping, any results with the patch? mkdir -p /etc/portage/patches/dev-qt/qtwebkit-5.212.0_pre20180120 Make the file with name qtwebkit-5.212.0_pre20180120-JSC_HOST_CALL.patch and place it in that directory. Place the following in the file: diff --git a/Source/WebCore/bindings/js/JSImageConstructor.cpp b/Source/WebCore/bindings/js/JSImageConstructor.cpp index 9236906..de553f5 100644 --- a/Source/WebCore/bindings/js/JSImageConstructor.cpp +++ b/Source/WebCore/bindings/js/JSImageConstructor.cpp @@ -44,7 +44,7 @@ template<> JSValue JSImageConstructor::prototypeForStructure(VM& vm, const JSDOM return JSHTMLElement::getConstructor(vm, &globalObject); } -template<> EncodedJSValue JSImageConstructor::construct(ExecState* state) +template<> EncodedJSValue JSC_HOST_CALL JSImageConstructor::construct(ExecState* state) { JSImageConstructor* jsConstructor = jsCast<JSImageConstructor*>(state->callee()); Document* document = jsConstructor->document(); And then emerge -1 dev-qt/qtwebkit Created attachment 574926 [details, diff]
qtwebkit-5.212.0_pre20180120-JSC_HOST_CALL.patch
Is that meant as confirmation that the patch works? Yes, the patch works. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c9ed1344b1942cf32ffc2c45a5a6bbe1ab504688 commit c9ed1344b1942cf32ffc2c45a5a6bbe1ab504688 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2019-05-02 21:18:29 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2019-05-08 16:59:34 +0000 dev-qt/qtwebkit: Fix js build error Closes: https://bugs.gentoo.org/680912 Package-Manager: Portage-2.3.66, Repoman-2.3.12 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> ...webkit-5.212.0_pre20180120-js-build-error.patch | 34 ++++++++++++++++++++++ .../qtwebkit/qtwebkit-5.212.0_pre20180120.ebuild | 1 + 2 files changed, 35 insertions(+) |