Bug 680860

Summary:	dev-lang/go: meaninglessly unpacks binpackages for all possible systems
Product:	Gentoo Linux	Reporter:	Michał Górny <mgorny>
Component:	Current packages	Assignee:	William Hubbs <williamh>
Status:	RESOLVED FIXED
Severity:	normal	CC:	spiderx
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/11704
Whiteboard:
Package list:		Runtime testing required:	---

Description Michał Górny archtester

2019-03-18 14:19:49 UTC

Apparently the new release of go involves humongous checkout, so please add a check-reqs disk space check so that it wouldn't exhaust all the space in /tmp/portage without warning.

Comment 1 Michał Górny archtester

2019-03-18 14:31:53 UTC

Actually, I see now that it unpacks bootstrap archives for all systems which makes no sense.  Besides wasting a lot of disk space and time, it causes disk wear and for no reason whatsoever:

>>> Unpacking source...
>>> Unpacking go1.12.1.src.tar.gz to /var/tmp/portage/dev-lang/go-1.12.1/work                                                                     
>>> Unpacking go-linux-amd64-bootstrap-1.8.tbz to /var/tmp/portage/dev-lang/go-1.12.1/work                                                        
>>> Unpacking go-linux-arm-bootstrap-1.8.tbz to /var/tmp/portage/dev-lang/go-1.12.1/work                                                          
>>> Unpacking go-linux-arm64-bootstrap-1.8.tbz to /var/tmp/portage/dev-lang/go-1.12.1/work                                                        
>>> Unpacking go-linux-ppc64-bootstrap-1.8.tbz to /var/tmp/portage/dev-lang/go-1.12.1/work                                                        
>>> Unpacking go-linux-ppc64le-bootstrap-1.8.tbz to /var/tmp/portage/dev-lang/go-1.12.1/work                                                      
>>> Unpacking go-linux-s390x-bootstrap-1.8.tbz to /var/tmp/portage/dev-lang/go-1.12.1/work                                                        
>>> Unpacking go-linux-386-bootstrap-1.8.tbz to /var/tmp/portage/dev-lang/go-1.12.1/work                                                          
>>> Unpacking go-freebsd-amd64-bootstrap-1.8.tbz to /var/tmp/portage/dev-lang/go-1.12.1/work
>>> Unpacking go-freebsd-386-bootstrap-1.8.tbz to /var/tmp/portage/dev-lang/go-1.12.1/work
>>> Unpacking go-darwin-amd64-bootstrap-1.8.tbz to /var/tmp/portage/dev-lang/go-1.12.1/work

Comment 2 William Hubbs gentoo-dev

2019-03-18 15:12:53 UTC


*** This bug has been marked as a duplicate of bug 680688 ***

Comment 3 Michał Górny archtester

2019-04-16 06:28:05 UTC

As explained, this is about unpacking and not fetching, and unpacking *can* be fixed.

Comment 4 Larry the Git Cow gentoo-dev

2019-04-24 18:06:49 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6b8aa7f8d6fe088fc68fde671bc20d5b061e0507

commit 6b8aa7f8d6fe088fc68fde671bc20d5b061e0507
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-04-16 06:25:39 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2019-04-24 18:04:56 +0000

    dev-lang/go: Unpack bootstrap archive for current platform only
    
    Unpack the bootstrap archive for the current platform rather than
    all bootstrap tarballs in SRC_URI.  This provides significant space
    savings during build.
    
    Closes: https://bugs.gentoo.org/680860
    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 dev-lang/go/go-1.12.4.ebuild | 5 ++++-
 dev-lang/go/go-9999.ebuild   | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)