Bug 680590

Summary:	www-apps/gitea-1.7.4 - no sqlite_unlock_notify
Product:	Gentoo Linux	Reporter:	Felix Neumärker <xdch47>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	normal	CC:	gen2xmach1ne, gentoo, hydrapolic, prote, proxy-maint
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/10961 https://github.com/gentoo/gentoo/pull/11387 https://bugs.gentoo.org/show_bug.cgi?id=684166
Whiteboard:
Package list:		Runtime testing required:	---

Description Felix Neumärker 2019-03-16 10:18:09 UTC

Was there any reason to completely ignore the work that has been done in https://github.com/gentoo/gentoo/pull/10961 ?

At least why do not build with sqlite_unlock_notify ? 
E.g see: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234709 ?

Further possible improvements, which have been ignored:
 (my latest version is: https://github.com/xdch47/gpo-xdch47/blob/master/www-apps/gitea/gitea-1.7.4-r1.ebuild)

  - src_test ()
  - useflags for pam and sqlite
  - cleanup inherit (make is use instead of golang-build)
  -
  - DRONE_TAG=${PV}
  (- moving the config to etc?)

Just to clearify and for the next time:
Is it because the `new` ebuild is bad for some reason?
Is it because there are too much changes?
Is it because contributions are unwanted?
Or was it to chaotic?

Comment 1 Tomáš Mózes 2019-03-17 00:42:43 UTC

I don't know why your PR hasn't been merged. However, since there was no 1.7.4 bump I tried opening a minimal PR so now users can have a more secure version. If you check the diff, some of the work was already incorporated (the initd change, logrotate drop, the service file update). They closed both bugs on b.g.o.

In https://github.com/gentoo/gentoo/pull/11387 there are a few more changes:
- complete confd and a newer initd
- the sqlite improvement
- tests
- config file move to /etc/gitea

Comment 2 Felix Neumärker 2019-03-17 07:51:42 UTC

Yes, fine no worries - I'm happy that your PR finally made it, at least there is now a up-to-date version in the main tree :)

For the pending PR:
When moving config to etc, maybe it's not wrong to mention that, the user should adapt the .ssh/authorized_keys and the gitea-repositories hooks, since the old configuration path is hard-coded there.

Comment 3 Tomáš Mózes 2019-03-17 09:04:29 UTC

(In reply to Felix Neumärker from comment #2)
> When moving config to etc, maybe it's not wrong to mention that, the user
> should adapt the .ssh/authorized_keys and the gitea-repositories hooks,
> since the old configuration path is hard-coded there.

Good point, since I don't use ssh I haven't realized this. Could you please attach a patch to the ebuild here? I'll then apply to the PR.

Comment 4 Larry the Git Cow gentoo-dev

2019-04-21 21:45:25 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d8b847da354d330a40a67a2971bbb851744a4ec2

commit d8b847da354d330a40a67a2971bbb851744a4ec2
Author:     Tomas Mozes <hydrapolic@gmail.com>
AuthorDate: 2019-03-17 00:27:22 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-04-21 21:33:07 +0000

    www-apps/gitea: bump to 1.7.6
    
    Thanks to Felix Neumärker and Pierre-Olivier Mercier
    for patches.
    
    Closes: https://bugs.gentoo.org/680590
    Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/11387
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 www-apps/gitea/Manifest               |  1 +
 www-apps/gitea/files/gitea.confd-r1   | 14 ++++++
 www-apps/gitea/files/gitea.initd-r2   | 22 +++++++++
 www-apps/gitea/files/gitea.service-r1 | 28 ++++++++++++
 www-apps/gitea/gitea-1.7.6.ebuild     | 85 +++++++++++++++++++++++++++++++++++
 5 files changed, 150 insertions(+)