Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 680132

Summary: sys-power/acpid - add scripts for backlight brightness control
Product: Gentoo Linux Reporter: Sam <sambesselink>
Component: Current packagesAssignee: Andriy Utkin (RETIRED) <andrey_utkin>
Status: RESOLVED WONTFIX    
Severity: normal Keywords: EBUILD, PATCH
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Ebuild for acpid with acpilight RDEPEND and brightness{up,down} scripts
brightnessdown script
brightnessup script

Description Sam 2019-03-12 14:26:35 UTC
Two advances in backlight brightness control for linux have vastly improved the situatoin for laptop owners using gentoo: sys-power/acpid allows easy handling of acpi events and sys-power/acpilight allows setting backlight in a non-X, device-independent way.

Currently, gentoo doesn't integrate these two. This ebuild fixes this:
- it adds the 'brightness' USE flag which toggles an sys-power/acpilight RDEPEND
- if brightness is set, two tiny scripts are installed in /etc/acpid/events/
- these scripts call xbacklight on brightnessup or brightnessdown events

Reproducible: Always
Comment 1 Sam 2019-03-12 14:28:35 UTC
Created attachment 568768 [details]
Ebuild for acpid with acpilight RDEPEND and brightness{up,down} scripts
Comment 2 Sam 2019-03-12 14:28:58 UTC
Created attachment 568770 [details]
brightnessdown script
Comment 3 Sam 2019-03-12 14:29:14 UTC
Created attachment 568772 [details]
brightnessup script
Comment 4 Andriy Utkin (RETIRED) gentoo-dev 2019-03-15 14:05:11 UTC
Looks very useful, thanks for your work Sam!

Also thanks for clear outline of what you're proposing.

I'd kindly ask you, however, to approach upstream maintainer, Ted Felix, with your patches, so that all Linux users could benefit from your work! Gentoo prefers upstreaming patches over hoarding them internally.

Also to best of my knowledge it is not recommended to put optional runtime dependencies into USE flags, so I am not confident I should take ebuild changes.

Does that sound alright to you?
Comment 5 Andriy Utkin (RETIRED) gentoo-dev 2019-03-24 23:43:09 UTC
More than a week, no objections from the contributor. Closing.