Bug 680046

Summary:	media-sound/lmms-1.2.0_rcx fails to build with media-sound/fluidsynth-2.0.x due to API change
Product:	Gentoo Linux	Reporter:	jorgicio <jpizarrocallejas>
Component:	Current packages	Assignee:	Alexis Ballier <aballier>
Status:	RESOLVED FIXED
Severity:	normal	CC:	audvare, polynomial-c, proaudio
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://github.com/LMMS/lmms/commit/c2e4f5a28d1612a706b8bee6d37b5ecc0bc38794
See Also:	https://github.com/LMMS/lmms/issues/4640
Whiteboard:
Package list:		Runtime testing required:	---

Description jorgicio 2019-03-11 16:56:05 UTC

Hi! I noted that fluidsynth was upgraded to 2.0 version, which leads in an API change. Packages like LMMS fails to build with that version because of that. I posted the URL where the topic is discussed and I found the solution posted in the Github issue (the URL is in this bug).

Someone posted a PR and now I "turned" it into a patch: https://github.com/LMMS/lmms/commit/c2e4f5a28d1612a706b8bee6d37b5ecc0bc38794.patch

Applied and it builds fine.

Thanks.

Reproducible: Always

Comment 1 Andrew Udvare 2019-03-11 23:09:28 UTC

(In reply to jorgicio from comment #0)
> Hi! I noted that fluidsynth was upgraded to 2.0 version, which leads in an
> API change. Packages like LMMS fails to build with that version because of
> that. I posted the URL where the topic is discussed and I found the solution
> posted in the Github issue (the URL is in this bug).
> 
> Someone posted a PR and now I "turned" it into a patch:
> https://github.com/LMMS/lmms/commit/c2e4f5a28d1612a706b8bee6d37b5ecc0bc38794.
> patch
> 
> Applied and it builds fine.
> 
> Thanks.
> 
> Reproducible: Always

Builds fine but does it work?

Comment 2 jorgicio 2019-03-11 23:14:36 UTC

(In reply to Andrew Udvare from comment #1)
> (In reply to jorgicio from comment #0)
> > Hi! I noted that fluidsynth was upgraded to 2.0 version, which leads in an
> > API change. Packages like LMMS fails to build with that version because of
> > that. I posted the URL where the topic is discussed and I found the solution
> > posted in the Github issue (the URL is in this bug).
> > 
> > Someone posted a PR and now I "turned" it into a patch:
> > https://github.com/LMMS/lmms/commit/c2e4f5a28d1612a706b8bee6d37b5ecc0bc38794.
> > patch
> > 
> > Applied and it builds fine.
> > 
> > Thanks.
> > 
> > Reproducible: Always
> 
> Builds fine but does it work?

Yes, it does, I ran it after building and all works fine as expected.

Comment 3 Larry the Git Cow gentoo-dev

2019-03-13 14:31:25 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7e1ae9894e61e25cd5dc3197597fd54e27758127

commit 7e1ae9894e61e25cd5dc3197597fd54e27758127
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2019-03-13 14:22:41 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2019-03-13 14:31:15 +0000

    media-sound/lmms: Bump to version 1.2.0_rc8
    
    Closes: https://bugs.gentoo.org/680046
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 media-sound/lmms/Manifest              |   1 +
 media-sound/lmms/lmms-1.2.0_rc8.ebuild | 107 +++++++++++++++++++++++++++++++++
 2 files changed, 108 insertions(+)