Bug 67915 – amarok 1.0.2 and 1.1.1 cjk patch

• Product: Gentoo Linux
• Status: RESOLVED DUPLICATE

[Description Jackey Yang ("timeout" in forum) 2004-10-17 11:46:29 UTC]

cjk patch update for amarok 1.0.2 and 1.1.1

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

[Comment 1 Jackey Yang ("timeout" in forum) 2004-10-17 11:47:07 UTC]

Created attachment 42045 [details, diff]
amarok-1.0.2-cjk.diff

Added amarok-1.0.2-cjk.diff

[Comment 2 Jackey Yang ("timeout" in forum) 2004-10-17 11:47:38 UTC]

Created attachment 42046 [details, diff]
amarok-1.1.1-cjk.diff

Added amarok-1.1.1-cjk.diff

[Comment 3 Jeremy Huddleston (RETIRED) 2004-10-17 13:56:28 UTC]

cjk: Please test out these patches and add them if they work well for you.

[Comment 4 Jackey Yang ("timeout" in forum) 2004-10-17 13:59:12 UTC]

I found another problem - can not save cjk tags via amarok.
I am working on that now. I found the problem in metabundle.h
Need to handle cjk char there in order to save cjk tags.

[Comment 5 Mamoru KOMACHI (RETIRED) 2004-10-17 19:33:25 UTC]

All right. Jackey, when you are done I'll test the patch and include it.

[Comment 6 Jackey Yang ("timeout" in forum) 2004-10-24 20:30:03 UTC]

Comment on attachment 42046 [details, diff]
amarok-1.1.1-cjk.diff

Removed

[Comment 7 Jackey Yang ("timeout" in forum) 2004-10-24 20:31:51 UTC]

Created attachment 42530 [details, diff]
amarok-1.1.1-cjk.diff

Here we go, this should fix the previous problem.
Someone, please give a try and let me know if it works or not*^_^*

[Comment 8 Gregorio Guidi (RETIRED) 2004-11-09 01:52:55 UTC]

Have you submitted this patch to kde developers?

[Comment 9 Jackey Yang ("timeout" in forum) 2004-11-13 21:15:23 UTC]

i do not think so, it seems http://amarok.kde.org is down somehow.
New patch fixed the cjk tag saving problem, works perfect on
my Gentoo box and Magic Linux

[Comment 10 Jackey Yang ("timeout" in forum) 2004-11-13 21:15:54 UTC]

Created attachment 43906 [details]
Snapshot

[Comment 11 Mamoru KOMACHI (RETIRED) 2004-11-14 20:38:33 UTC]

Hi, Jackey, I tested amarok-1.1.1-cjk.diff.
It doesn't apply to 1.0.2 but applies cleanly to 1.1.1.
However, it does not work on Japanese tag.
http://www.madin.jp/music/mp3/chakufuku.mp3
is the one I tested, it doesn't show Japanese title
(probablly in SJIS) properly. Also, I tried to rename
title and author to Japanese name, but failed (amarok
crashed). I'm not sure if this is related to the patch
or 1.1.1 stability itself, but just FYI. Looking at
the original patch in files directory, I think it's
okay to update the patch though... (Please post
a URL of the Chinese mp3 you tested, so I can
test whether it works at least on Chinese environment)

[Comment 12 Gregorio Guidi (RETIRED) 2005-03-18 08:24:45 UTC]

*** This bug has been marked as a duplicate of 81940 ***