Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 678788

Summary: net-firewall/ipt_netflow-2.3 with kernel 5.0_rc7 - .../work/ipt-netflow-2.3/ipt_NETFLOW.c:2621:2: error: implicit declaration of function ‘do_gettimeofday’; did you mean ‘do_settimeofday64’? [-Werror=implicit-function-declaration]
Product: Gentoo Linux Reporter: Jeroen Roovers (RETIRED) <jer>
Component: Current packagesAssignee: Sergey Popov <pinkbyte>
Status: RESOLVED FIXED    
Severity: normal CC: netmon
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/aabc/ipt-netflow/issues/108
https://github.com/aabc/ipt-netflow/pull/110
https://github.com/aabc/ipt-netflow/issues/116
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: net-firewall:ipt_netflow-2.3:20190225-190631.log
emerge-info.txt
emerge-history.txt
environment
etc.portage.tbz2
net-firewall:ipt_netflow-2.3:20191228-135426.log
temp.tbz2

Description Jeroen Roovers (RETIRED) gentoo-dev 2019-02-25 19:20:06 UTC
Created attachment 566496 [details]
net-firewall:ipt_netflow-2.3:20190225-190631.log

Already fixed upstream but not released.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2019-02-25 19:21:43 UTC
Two errors, really:

  CC [M]  /home/jer/portage/net-firewall/ipt_netflow-2.3/work/ipt-netflow-2.3/ipt_NETFLOW.o
/home/jer/portage/net-firewall/ipt_netflow-2.3/work/ipt-netflow-2.3/ipt_NETFLOW.c: In function ‘netflow_export_pdu_v5’:
/home/jer/portage/net-firewall/ipt_netflow-2.3/work/ipt-netflow-2.3/ipt_NETFLOW.c:2621:2: error: implicit declaration of function ‘do_gettimeofday’; did you mean ‘do_settimeofday64’? [-Werror=implicit-function-declaration]
  do_gettimeofday(&tv);
  ^~~~~~~~~~~~~~~
  do_settimeofday64
/home/jer/portage/net-firewall/ipt_netflow-2.3/work/ipt-netflow-2.3/ipt_NETFLOW.c: In function ‘ipt_netflow_init’:
/home/jer/portage/net-firewall/ipt_netflow-2.3/work/ipt-netflow-2.3/ipt_NETFLOW.c:5510:43: error: invalid operands to binary << (have ‘long unsigned int (*)(void)’ and ‘int’)
   unsigned long memksize = (num_physpages << PAGE_SHIFT) / 1024;
                                           ^~
cc1: some warnings being treated as errors
Comment 2 Larry the Git Cow gentoo-dev 2019-06-19 05:35:47 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=360337d3df4eac17326a827f9ab5914de26dbfd9

commit 360337d3df4eac17326a827f9ab5914de26dbfd9
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2019-06-19 05:34:35 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2019-06-19 05:35:43 +0000

    net-firewall/ipt_netflow: Version 2.3_p20190619
    
    Package-Manager: Portage-2.3.67, Repoman-2.3.14
    Bug: https://bugs.gentoo.org/show_bug.cgi?id=678788
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 net-firewall/ipt_netflow/Manifest                  |   1 +
 .../ipt_netflow/ipt_netflow-2.3_p20190619.ebuild   | 103 +++++++++++++++++++++
 2 files changed, 104 insertions(+)
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2019-06-19 05:40:39 UTC
(In reply to Larry the Git Cow from comment #2)
> The bug has been referenced in the following commit(s):
> 
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=360337d3df4eac17326a827f9ab5914de26dbfd9
> 
> commit 360337d3df4eac17326a827f9ab5914de26dbfd9
> Author:     Jeroen Roovers <jer@gentoo.org>
> AuthorDate: 2019-06-19 05:34:35 +0000
> Commit:     Jeroen Roovers <jer@gentoo.org>
> CommitDate: 2019-06-19 05:35:43 +0000
> 
>     net-firewall/ipt_netflow: Version 2.3_p20190619
>     
>     Package-Manager: Portage-2.3.67, Repoman-2.3.14
>     Bug: https://bugs.gentoo.org/show_bug.cgi?id=678788
>     Signed-off-by: Jeroen Roovers <jer@gentoo.org>
> 
>  net-firewall/ipt_netflow/Manifest                  |   1 +
>  .../ipt_netflow/ipt_netflow-2.3_p20190619.ebuild   | 103
> +++++++++++++++++++++
>  2 files changed, 104 insertions(+)

This ebuild should succeed with both 5.0 and 5.2 kernel changes.
Comment 4 Larry the Git Cow gentoo-dev 2019-12-27 18:51:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=34f70c17dbb515c22d3590b0b37dc987f014ebc6

commit 34f70c17dbb515c22d3590b0b37dc987f014ebc6
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2019-12-27 18:50:34 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2019-12-27 18:51:45 +0000

    net-firewall/ipt_netflow: Stable for amd64 x86 too
    
    Package-Manager: Portage-2.3.84, Repoman-2.3.20
    Closes: https://bugs.gentoo.org/659266
    Closes: https://bugs.gentoo.org/660936
    Closes: https://bugs.gentoo.org/678788
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 net-firewall/ipt_netflow/ipt_netflow-2.4.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 Toralf Förster gentoo-dev 2019-12-28 14:45:33 UTC
it is still an issue at unstable amd64 tinderbox image 17.1_hardened-20191223-091554 (see bug 678788)
Comment 6 Toralf Förster gentoo-dev 2019-12-28 14:45:36 UTC
Created attachment 601552 [details]
emerge-info.txt
Comment 7 Toralf Förster gentoo-dev 2019-12-28 14:45:39 UTC
Created attachment 601554 [details]
emerge-history.txt
Comment 8 Toralf Förster gentoo-dev 2019-12-28 14:45:42 UTC
Created attachment 601556 [details]
environment
Comment 9 Toralf Förster gentoo-dev 2019-12-28 14:45:45 UTC
Created attachment 601558 [details]
etc.portage.tbz2
Comment 10 Toralf Förster gentoo-dev 2019-12-28 14:45:48 UTC
Created attachment 601560 [details]
net-firewall:ipt_netflow-2.3:20191228-135426.log
Comment 11 Toralf Förster gentoo-dev 2019-12-28 14:45:51 UTC
Created attachment 601562 [details]
temp.tbz2
Comment 12 Jeroen Roovers (RETIRED) gentoo-dev 2019-12-29 13:20:25 UTC
(In reply to Toralf Förster from comment #5)
> it is still an issue at unstable amd64 tinderbox image
> 17.1_hardened-20191223-091554 (see bug 678788)

So while 2.4 has the fix and is stable, you insist that people who desperately ignore the upgrade path and stick with 2.3 will still see this problem?
Comment 13 Larry the Git Cow gentoo-dev 2019-12-29 13:21:25 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fac0c38880319604baead2e643e9bdc3f99e2232

commit fac0c38880319604baead2e643e9bdc3f99e2232
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2019-12-29 13:20:58 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2019-12-29 13:21:21 +0000

    net-firewall/ipt_netflow: Old
    
    Package-Manager: Portage-2.3.84, Repoman-2.3.20
    
    Closes: https://bugs.gentoo.org/678788
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 net-firewall/ipt_netflow/Manifest               |   1 -
 net-firewall/ipt_netflow/ipt_netflow-2.3.ebuild | 100 ------------------------
 2 files changed, 101 deletions(-)