| Summary: | sys-devel/prelink - /etc/cron.daily/prelink complains when it inspects /sbin/init without first checking to see whether it exists | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Enne Eziarc <gentoo+bugs> |
| Component: | Current packages | Assignee: | Gentoo Toolchain Maintainers <toolchain> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Keywords: | PATCH |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | use `prelink -p` instead of `ldd` in prelink.cron | ||
The patch looks reasonable. Rest of code uses absolute path to 'prelink' binary. Are you familiar with git to attach something I can just 'git am'? While at it i suggest splitting patch in two: 1. patch to consolidate logic into one helper. straightforward, candidate to apply instantly. 2. patch to query prelink cache. I'm a bit nervous about it and would like to explore stability of 'prelink -p' output. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d1be2b4aae769dc42b8dee38ebac5439458207ff commit d1be2b4aae769dc42b8dee38ebac5439458207ff Author: Sergei Trofimovich <slyfox@gentoo.org> AuthorDate: 2019-08-23 06:48:10 +0000 Commit: Sergei Trofimovich <slyfox@gentoo.org> CommitDate: 2019-08-23 06:49:01 +0000 sys-devel/prelink: ignore warnings from 'ldd /sbin/init' /sbin/init might not exist at all. Let's not generate text output in this case. Reported-by: Anthony Parsons Closes: https://bugs.gentoo.org/678348 Package-Manager: Portage-2.3.72, Repoman-2.3.17 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> sys-devel/prelink/files/prelink.cron | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) |
Created attachment 565814 [details, diff] use `prelink -p` instead of `ldd` in prelink.cron The cron script introspects /sbin/init without first checking to see whether it exists, leading to cron email spam when it doesn't. Enclosed is a patch that reads prelink's own cache file instead. A minor side benefit is that there's no more need to silence errors to hack around the presence of linux-vdso in the list.