Summary: | media-libs/allegro-5.2.4.0 : [QA] One or more CMake variables were not used by the project: | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
Component: | Current packages | Assignee: | Gentoo Games <games> |
Status: | RESOLVED FIXED | ||
Severity: | QA | CC: | bkohler |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
etc.portage.tbz2
media-libs:allegro-5.2.4.0:20190214-143951.log |
Description
Toralf Förster
2019-02-14 16:01:04 UTC
Created attachment 565344 [details]
etc.portage.tbz2
Created attachment 565346 [details]
media-libs:allegro-5.2.4.0:20190214-143951.log
FYI this is triggered with USE=-alsa. Maybe these 4 options should only be appended to mycmakeargs 'if use alsa'. Possibly also REQUIRED_USE ? Reproduces with USE="-alsa -openal -oss -pulseaudio" If any one of these flags is enabled then there is no warning. An easy way out would be to force at least one audio backend. Is there some use-case for installing w/o audio support? I don't know about use cases. Is it not simple enough? if use alsa || use openal || use oss || use pulseaudio; then mycmakeargs+=( -DWANT_FLAC=$(usex flac) -DWANT_MODAUDIO=$(usex dumb) -DWANT_OPUS=$(usex opus) -DWANT_VORBIS=$(usex vorbis) ) fi maybe also with: elif use flac || use dumb || use opus || use vorbis; then ewarn "All audio backends are disabled so audio codec support cannot be enabled" fi Or something like that? It's not ideal if USE=flac still silently disables flac, for example (In reply to Ben Kohler from comment #7) > maybe also with: > > elif use flac || use dumb || use opus || use vorbis; then > ewarn "All audio backends are disabled so audio codec support cannot be > enabled" > fi > > > Or something like that? It's not ideal if USE=flac still silently disables > flac, for example Looks nice but I doubt anybody will ever notice such a warning in src_configure()... How about this? IUSE="... +sound ..." REQUIRED_USE="... sound? ( || ( alsa openal oss pulseaudio ) ) sound? ( || ( dumb flac opus vorbis ) )" I thank you can combine those like "sound? ( || ( alsa openal oss pulseaudio ) || ( dumb flac opus vorbis )" but otherwise yeah that seems reasonable No that's not right:( The library can also read WAV, so USE="sound -dumb -flac -opus -vorbis" would be correct. Maybe just REQUIRED_USE="|| ( alsa openal oss pulseaudio )" is better, otherwise it may become too complex... The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=81cf1a0cfd9db6aee35b2a6a3d2e973d1d87dda2 commit 81cf1a0cfd9db6aee35b2a6a3d2e973d1d87dda2 Author: Stefan Strogin <steils@gentoo.org> AuthorDate: 2019-05-24 07:46:40 +0000 Commit: Stefan Strogin <steils@gentoo.org> CommitDate: 2019-05-24 10:08:00 +0000 media-libs/allegro: bump version to 5.2.5.0 Closes: https://bugs.gentoo.org/666996 Closes: https://bugs.gentoo.org/672634 Closes: https://bugs.gentoo.org/678002 Closes: https://bugs.gentoo.org/684808 Package-Manager: Portage-2.3.66, Repoman-2.3.12 Signed-off-by: Stefan Strogin <steils@gentoo.org> media-libs/allegro/Manifest | 1 + media-libs/allegro/allegro-5.2.5.0.ebuild | 88 +++++++++++++++++++++++++++++++ 2 files changed, 89 insertions(+) |