| Summary: | app-i18n/ibus-1.5.19 - emojier.vala:915.48-916.62: error: Assignment: Cannot convert from `GLib.SList<string>' to `GLib.SList<weak string>?' | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Cynede (RETIRED) <cynede> |
| Component: | Current packages | Assignee: | CJK Team <cjk> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | leio |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/11048 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | Build log of reporter of this bug | ||
|
Description
Cynede (RETIRED)
2019-02-14 10:38:27 UTC
You should already be aware that you ought to attach the build log, not point to a paste site. Please also look to making it actually work with newer vala. Old vala won't stick around forever. Hopefully upstream will take care of it though, if already hasn't in GIT (in which case consider grabbing the relevant patch(es) from there instead of limiting MAX; though unpatched revisions should get the MAX added) Created attachment 565444 [details]
Build log of reporter of this bug
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b0c9ca2ac13b429d571a52becd533b73f7035cab commit b0c9ca2ac13b429d571a52becd533b73f7035cab Author: Mikhail Pukhlikov <cynede@gentoo.org> AuthorDate: 2019-02-14 08:45:28 +0000 Commit: Akinori Hattori <hattya@gentoo.org> CommitDate: 2019-02-20 14:18:55 +0000 app-i18n/ibus: limit max vala version, add python3.7 Closes: https://bugs.gentoo.org/677972 Closes: https://github.com/gentoo/gentoo/pull/11048 Signed-off-by: Mikhail Pukhlikov <cynede@gentoo.org> Signed-off-by: Akinori Hattori <hattya@gentoo.org> Package-Manager: Portage-2.3.60, Repoman-2.3.12 app-i18n/ibus/ibus-1.5.19.ebuild | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) The trouble is in the emoji part of the code. app-i18n/ibus-1.5.19[-emoji] works just fine with the latest vala. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4967740ab488283e7caf3e4e651bc00e2eaf689e commit 4967740ab488283e7caf3e4e651bc00e2eaf689e Author: Akinori Hattori <hattya@gentoo.org> AuthorDate: 2019-02-25 12:43:07 +0000 Commit: Akinori Hattori <hattya@gentoo.org> CommitDate: 2019-02-25 12:45:08 +0000 app-i18n/ibus: fix build with >=dev-lang/vala-0.43.4 Bug: https://bugs.gentoo.org/677972 Signed-off-by: Akinori Hattori <hattya@gentoo.org> Package-Manager: Portage-2.3.51, Repoman-2.3.11 app-i18n/ibus/files/ibus-1.5.19-vala-0.43.4.patch | 191 ++++++++++++++++++++++ app-i18n/ibus/ibus-1.5.19.ebuild | 6 +- 2 files changed, 195 insertions(+), 2 deletions(-) 1.5.18 in stable isn't patched, nor does it set a VALA_MAX_API_VERSION. To not have to worry about this breaking if a newer vala happens to be stabilized before ibus-1.5.19 - please put an appropriate VALA_MAX_API_VERSION in the 1.5.18 ebuild. That said, looking at the patch, it looks like there actually is no issues with in-tree vala versions, given that the patch is for vala-0.43 dev release (which Cynede uses via his overlay), not for 0.42 or older. If so, VALA_MAX_API_VERSION="0.42" in the 1.5.18 ebuild won't hurt either (we'll have 0.44 in main tree only in March probably as that's when stable version comes out, but will take at least a month to stabilize, etc). The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bc567f091355a2bb2376b5b07d00680a9cbe42e1 commit bc567f091355a2bb2376b5b07d00680a9cbe42e1 Author: Akinori Hattori <hattya@gentoo.org> AuthorDate: 2019-03-02 12:29:22 +0000 Commit: Akinori Hattori <hattya@gentoo.org> CommitDate: 2019-03-02 12:29:22 +0000 app-i18n/ibus: restrict >=dev-lang/vala-0.44 Bug: https://bugs.gentoo.org/677972 Signed-off-by: Akinori Hattori <hattya@gentoo.org> Package-Manager: Portage-2.3.51, Repoman-2.3.11 app-i18n/ibus/ibus-1.5.18.ebuild | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) |