Bug 677522 – gui-wm/sway - meson.build:130:2: ERROR: Problem encountered: git is required to make the version string

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Arnaud Vallette d'Osia 2019-02-09 07:16:05 UTC]

As per: https://github.com/swaywm/sway/issues/2931
sway should depend on git at build time.
(fails to build without it)


Reproducible: Always

Steps to Reproduce:
unmerge git
emerge sway

[Comment 1 Tomáš Mózes 2019-02-09 09:23:47 UTC]

Perhaps you can replace that git call with $PV?

[Comment 2 Niccolò Scatena 2019-02-09 13:00:45 UTC]

No, Sway should not depend on git (only v9999 should, and it already depends on it). This happens only with `sway-1.0_rc1` because the ebuild author forgot to pass the `sway-version` parameter to meson.
There is this PR stuck on github by 11 days with the correct ebuild: https://github.com/gentoo/gentoo/pull/10932

[Comment 3 Niccolò Scatena 2019-02-09 13:13:14 UTC]

I'm rebasing the PR over the work by Matthew Thode to fix this (and other) issues.

[Comment 4 Niccolò Scatena 2019-02-09 18:08:22 UTC]

I've seen now that even sway-1.0_rc1 passes the `sway-version` param to meson, so it should work even without git.

Arnauld please, can you provide build log of sway-1.0_rc1 without git installed? Se this to enable build logs: https://wiki.gentoo.org/wiki/Portage_log#Build_logs

[Comment 5 Arnaud Vallette d'Osia 2019-02-14 12:12:12 UTC]

Just read your message, Niccolo, sorry for the delay.
that's from portage rc2 ebuild, but it should do?
https://0x0.st/zz3f.log

[Comment 6 Arnaud Vallette d'Osia 2019-02-28 20:28:49 UTC]

Changed the title to reflect ebuild its new location in gui-wm.

Version 1.0_rc4 is still affected.

[Comment 7 Matthew Thode ( prometheanfire ) 2019-03-01 17:07:43 UTC]

I'd like a build log with the error with latest (currently rc4).

[Comment 8 Arnaud Vallette d'Osia 2019-03-01 18:24:56 UTC]

https://0x0.st/z-F2.txt
this should do?

[Comment 9 Matthew Thode ( prometheanfire ) 2019-03-01 18:48:16 UTC]

yep, that works, but can you try with rc4 (iirc the dep was removed upstream in rc3/4)

[Comment 10 Arnaud Vallette d'Osia 2019-03-01 19:25:28 UTC]

Sorry, I compared the log with previous one and uploaded the wrong one...
https://0x0.st/z-Fn.txt
...still happening though.

[Comment 11 Matthew Thode ( prometheanfire ) 2019-03-01 20:56:09 UTC]

ok, upstream said meson bug, can you try updating meson (0.49.2)?

[Comment 12 Arnaud Vallette d'Osia 2019-03-04 20:40:33 UTC]

It works indeed with meson 0.49.2... you deserve praises for your concern.

[Comment 13 Andreas Sturmlechner 2019-03-30 17:41:55 UTC]

*** Bug 682040 has been marked as a duplicate of this bug. ***