Bug 677250 – =mail-filter/spamassassin-3.4.2: sa-update can't fetch rules from mirrors containing paths in url

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Marcin Mirosław 2019-02-04 13:53:42 UTC]

If MIRRORED.BY contains path to rules e.g. http://update.sa.mejor.pl/sa-updates/ sa-update can't fetch rules.
See bug:
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7623

Reproducible: Always

[Comment 1 Marcin Mirosław 2019-02-04 14:12:59 UTC]

I'll prepare pull request with fix for the bug.

[Comment 2 Marcin Mirosław 2019-02-04 14:53:06 UTC]

https://github.com/gentoo/gentoo/pull/10979

[Comment 3 Philippe Chaintreuil 2019-02-04 17:18:42 UTC]

Assigning bug over to you Marcin since you're obviously in the driver seat on this one.  I've added myself to the CC list.

[Comment 4 Philippe Chaintreuil 2019-02-17 02:26:52 UTC]

Marcin: just making sure you're aware your Github PR got kicked back to you because it needs your explicit sign-off[1] in the commit message.

[1] https://www.gentoo.org/glep/glep-0076.html#certificate-of-origin

[Comment 5 Marcin Mirosław 2019-02-17 12:37:39 UTC]

Thanks Philippe,
I spent hours fighting with git hell (merge and rebase problems) and I need to take a breath before I try again :)

[Comment 6 Larry the Git Cow 2019-03-02 05:01:42 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5225641c114c95e5524d3794af84170ded43aada

commit 5225641c114c95e5524d3794af84170ded43aada
Author:     Marcin Mirosław <[e-mail]>
AuthorDate: 2019-02-18 12:09:48 +0000
Commit:     Michael Orlitzky <[e-mail]>
CommitDate: 2019-03-02 05:00:36 +0000

    mail-filter/spamassassin: restore support for paths in rules mirror URL's
    
    sa-update couldn't fetch rules from mirror if files were in paths
    
    Bug: https://bugs.gentoo.org/677250
    Bug: https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7623
    Signed-off-by: Marcin Mirosław <[e-mail]>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11
    Signed-off-by: Michael Orlitzky <[e-mail]>

 .../files/spamassassin-3.4.2-bug_7623_p1.patch     |  13 +
 .../files/spamassassin-3.4.2-bug_7623_p2.patch     |  15 ++
 .../spamassassin/spamassassin-3.4.2-r5.ebuild      | 286 +++++++++++++++++++++
 3 files changed, 314 insertions(+)

[Comment 7 Michael Orlitzky 2019-03-02 05:09:42 UTC]

Thanks Marcin. Keep in mind that you can use the "Closes:" tag instead of "Bug:" to automatically close these with your commit.

In fact, you can close the PR in the same way, with "Closes: https://github.com/path/to/pr", but that only works if you update your commit AFTER you create the PR (because you need to create it before you know the path...)