Summary: | dev-util/gitstrap-0.1.7 - Command line tool to bootstrap Github repository | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | g4s8.public |
Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
Status: | UNCONFIRMED --- | ||
Severity: | normal | CC: | g4s8.public |
Priority: | Normal | Keywords: | EBUILD, PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://github.com/g4s8/gitstrap | ||
See Also: | https://github.com/gentoo/gentoo/pull/10936 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
gitstrap-0.1.7.ebuild
gitstrap-0.1.7.ebuild metadata.xml Manifest gitstrap-0.1.7.ebuild |
Description
g4s8.public
2019-01-29 19:45:39 UTC
Submitted PR: https://github.com/gentoo/gentoo/pull/10936 (slightly changed ebuild to fix repoman warnings) Comment on attachment 563240 [details] gitstrap-0.1.7.ebuild ># Copyright 1999-2018 Gentoo Foundation ># Distributed under the terms of the GNU General Public License v2 > >EAPI=6 Might as well have been 7. > >REPO="github.com/g4s8/${PN}" You set REPO >DESCRIPTION="Command line tool to bootstrap Github repository" >HOMEPAGE="https://github.com/g4s8/gitstrap" But also HOMEPAGE, which does the same and more. >SRC_URI="https://${REPO}/archive/${PV}.tar.gz" And then you might as well use HOMEPAGE instead of REPO, which you use nowhere else. >LICENSE="MIT" >SLOT="0" >KEYWORDS="~x86 ~amd64" >IUSE="test" > >DEPEND="dev-lang/go" >RDEPEND="dev-vcs/git" > >_go_get() { > local name=$1 > go get -v -u $name || die "'go get' failed to get $name" >} > >src_prepare() { > default > mkdir -pv $HOME/go/src/github.com/g4s8 || die > ln -snv $PWD $HOME/go/src/github.com/g4s8/gitstrap || die > _go_get github.com/google/go-github/github > _go_get golang.org/x/oauth2 > _go_get gopkg.in/yaml.v2 Looks like _fetch() done in src_prepare() to me. >} > >src_compile() { > local now=$(date -u +%Y.%m.%dT%H:%M:%S) Reproducible builds? > emake OUTPUT=lib BUILD_VERSION=${PV} BUILD_DATE=${now} lib || die > go build -o ${PN} ./cmd/${PN} || die >} > >src_test() { > emake OUTPUT=lib test || die >} > >src_install() { > dobin ${PN} || die "'${PN} installation failed" Extra '. > elog "Read the README for details: https://github.com/g4s8/gitstrap/" Like here. >} > (In reply to Jeroen Roovers from comment #2) > Comment on attachment 563240 [details] > gitstrap-0.1.7.ebuild > > ># Copyright 1999-2018 Gentoo Foundation > ># Distributed under the terms of the GNU General Public License v2 > > > >EAPI=6 > > Might as well have been 7. > > > > >REPO="github.com/g4s8/${PN}" > > You set REPO > > >DESCRIPTION="Command line tool to bootstrap Github repository" > >HOMEPAGE="https://github.com/g4s8/gitstrap" > > But also HOMEPAGE, which does the same and more. > > >SRC_URI="https://${REPO}/archive/${PV}.tar.gz" > > And then you might as well use HOMEPAGE instead of REPO, which you use > nowhere else. > > > >LICENSE="MIT" > >SLOT="0" > >KEYWORDS="~x86 ~amd64" > >IUSE="test" > > > >DEPEND="dev-lang/go" > >RDEPEND="dev-vcs/git" > > > >_go_get() { > > local name=$1 > > go get -v -u $name || die "'go get' failed to get $name" > >} > > > >src_prepare() { > > default > > mkdir -pv $HOME/go/src/github.com/g4s8 || die > > ln -snv $PWD $HOME/go/src/github.com/g4s8/gitstrap || die > > _go_get github.com/google/go-github/github > > _go_get golang.org/x/oauth2 > > _go_get gopkg.in/yaml.v2 > > Looks like _fetch() done in src_prepare() to me. > > >} > > > >src_compile() { > > local now=$(date -u +%Y.%m.%dT%H:%M:%S) > > Reproducible builds? > > > emake OUTPUT=lib BUILD_VERSION=${PV} BUILD_DATE=${now} lib || die > > go build -o ${PN} ./cmd/${PN} || die > >} > > > >src_test() { > > emake OUTPUT=lib test || die > >} > > > >src_install() { > > dobin ${PN} || die "'${PN} installation failed" > > Extra '. > > > elog "Read the README for details: https://github.com/g4s8/gitstrap/" > > Like here. > > >} > > Thanks for comments. I've fixed almost all issues: removed REPO variable, replaced with HOMEPAGE changed EAPI from 6 to 7 removed quote > Looks like _fetch() done in src_prepare() to me. I'm not sure about it, these lines downloads and installs build dependencies, what is the correct place to put them? > Reproducible builds? I checked the build by "ebuild gitstrap-0.1.7.ebuild manifest clean compile" command and by publishing to layman overlay. I commited and pushed these changes to same PR; but as package category was changed, should I close my PR and resubmit new one with correct category? Also it's not clear, do I need to add sign-of to commits in PR or gpg signing is enough? Sorry for so many questions, this is my first package. Created attachment 563364 [details]
gitstrap-0.1.7.ebuild
Updated ebuild attachment in case if it's not synchronizing with pull request
Created attachment 563368 [details]
metadata.xml
Added metadata.xml
Created attachment 563370 [details]
Manifest
Added Manifest file
Created attachment 566882 [details]
gitstrap-0.1.7.ebuild
|