Bug 676532

Summary:	net-misc/youtube-dl - src_test() connects to various sites on the Internet
Product:	Gentoo Linux	Reporter:	Elodia Annal <elodia.annal>
Component:	Current packages	Assignee:	Jeroen Roovers (RETIRED) <jer>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=703168
Whiteboard:
Package list:		Runtime testing required:	---

Description Elodia Annal 2019-01-27 16:34:50 UTC

All youtube-dl contact servers on the internet during the internet and thus violate the Gentoo policy.
From the devmanual [0] (pointed out by Michał Górny):

   Sometimes test suites (and other build-time programs) attempt to use remote or local network, or production servers running on the host. All of these are **strictly** forbidden. [...]

(emphasis mine). This violation is even severer as the test suite contacts NSFW websites and tries to download it, which is even illegal in some countries. Thus posing a real thread for people using this ebuild of Gentoo. Please stop that!
Setting severity to critical for these reasons.

The fix is simple and supported by upstream: Use the 'offlinetest' make target instead of the 'test' make target, i.e.

   emake offlinetest

(This fix would also solve issues #635996)

Thanks.

[0] https://devmanual.gentoo.org/ebuild-writing/functions/src_test/index.html#tests-that-require-network-or-service-access

Comment 1 Larry the Git Cow gentoo-dev

2019-01-28 18:30:10 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=122ab201e342645a4d3aac722fdae303230812c9

commit 122ab201e342645a4d3aac722fdae303230812c9
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2019-01-28 18:26:07 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2019-01-28 18:30:00 +0000

    net-misc/youtube-dl: Remove USE=offensive, add RESTRICT=test
    
    Bug: https://bugs.gentoo.org/show_bug.cgi?id=599928
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=605010
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=635996
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=643200
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=676532
    Package-Manager: Portage-2.3.58, Repoman-2.3.12
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 net-misc/youtube-dl/youtube-dl-2019.01.27.ebuild | 59 ++---------------------
 net-misc/youtube-dl/youtube-dl-99999999.ebuild   | 60 ++----------------------
 2 files changed, 7 insertions(+), 112 deletions(-)