Summary: | mail-mta/netqmail-1.06-r5 fails to build against dev-libs/openssl-1.1.0j | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Roy Bamford <neddyseagoon> |
Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | gentoobugs, graaff, mike, net-mail+disabled |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 592438 | ||
Attachments: |
mail-mta/netqmail-1.06-r5 build log
a patch for netqmail-1.05-tls-smtpauth-20070417.patch a standalone patch that could replace netqmail-1.05-tls-smtpauth-20070417.patch a subsequent patch to be applied on top of netqmail-1.05-tls-smtpauth-20070417.patch a standalone patch that could replace netqmail-1.05-tls-smtpauth-20070417.patch The Manifest file includes the netqmail-1.05-tls-smtpauth-20190114.patch Updated ebuild file for netqmail-1.06-r5 Failed patch on top of updated tls+auth patch |
Description
Roy Bamford
2019-01-10 09:18:17 UTC
From https://wiki.openssl.org/index.php/OpenSSL_1.1.0_Changes: "All structures in libssl public header files have been removed so that they are "opaque" to library users. You should use the provided accessor functions instead" So I looked up those functions there: https://www.openssl.org/docs/man1.1.1/man3/SSL_get_state.html https://www.openssl.org/docs/man1.1.0/crypto/X509_NAME_ENTRY_get_object.html https://www.openssl.org/docs/man1.1.0/ssl/SSL_get_info_callback.html https://www.openssl.org/docs/man1.1.1/man3/SSL_set_connect_state.html Since this effectively involves patching the netqmail-1.05-tls-smtpauth-20070417.patch, I provided the changes in three ways: - netqmail-1.05-tls-smtpauth-20070417.patch.patch is a patch for the patch - netqmail-1.05-tls-smtpauth-20160114.patch is a standalone patch that could replace netqmail-1.05-tls-smtpauth-20070417.patch - netqmail-1.06-openssl-1.1.patch is a subsequent patch to be applied on top of netqmail-1.05-tls-smtpauth-20070417.patch I wouldn't call myself confident enough in C or OpenSSL code to assume I did everything right, so I would love some feedback. Unfortunately I don't have a test environment to check the handling of bad certificates right now. Operation in a correctly working environment (my machines) seems to work fine though. Created attachment 561152 [details, diff]
a patch for netqmail-1.05-tls-smtpauth-20070417.patch
Created attachment 561154 [details, diff]
a standalone patch that could replace netqmail-1.05-tls-smtpauth-20070417.patch
Created attachment 561156 [details, diff]
a subsequent patch to be applied on top of netqmail-1.05-tls-smtpauth-20070417.patch
(In reply to Alexander Hof from comment #1) > - netqmail-1.05-tls-smtpauth-20160114.patch is a standalone patch that > could replace netqmail-1.05-tls-smtpauth-20070417.patch Typo in the file name, should be netqmail-1.05-tls-smtpauth-20190114.patch Created attachment 561158 [details, diff]
a standalone patch that could replace netqmail-1.05-tls-smtpauth-20070417.patch
Typo in the file name of previous patch.
I maintain a mirror with check sums here: https://mirror.alexh.name/qmail/netqmail/ I also wrote Frederik Vermeulen (maintainer of the original TLS patch) to consider including the changes to his line of patches (http://inoa.net/qmail-tls/). (In reply to Alexander Hof from comment #8) > I also wrote Frederik Vermeulen (maintainer of the original TLS patch) to > consider including the changes to his line of patches > (http://inoa.net/qmail-tls/). Upstream for the patch Frederik Vermeulen incorporated my and other's contributions in an updated patch: http://inoa.net/qmail-tls/netqmail-1.06-tls-20190322.patch Created attachment 576818 [details]
The Manifest file includes the netqmail-1.05-tls-smtpauth-20190114.patch
Replaced the netqmail-1.05-tls-smtpauth-20070417.patch file with new patch file netqmail-1.05-tls-smtpauth-20190114.patch in the Manifest file, file size, hashes, all there. This 20190114 patch is from Alexander Hof's mirror site mentioned in his comment.
Created attachment 576820 [details]
Updated ebuild file for netqmail-1.06-r5
The source uri of the new patch, netqmail-1.05-tls-smtpauth-20190114.patch, is pointing to Alexander Hof's mirror site mentioned in his comment.
Use with the Manifest file in prior attachment. Download the Manifest file and this file to your local portage folder, namely /usr/portage/mail-mta/netqmail, and emerge netqmail as usual, emerge should be completed without any problem.
This is a personal modification work, use at your own risk.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c4ab807c5baec32dccd38be6872256dc66c98cfc commit c4ab807c5baec32dccd38be6872256dc66c98cfc Author: Hans de Graaff <graaff@gentoo.org> AuthorDate: 2019-07-13 07:58:13 +0000 Commit: Hans de Graaff <graaff@gentoo.org> CommitDate: 2019-07-13 07:58:49 +0000 mail-mta/netqmail: new revision with openssl 1.1 compat Add updated patches that ensure compatibility with openssl 1.1.x. Based on patches by Alexander Hof and ebuild by Yida Zhang. Fixes: https://bugs.gentoo.org/675060 Signed-off-by: Hans de Graaff <graaff@gentoo.org> Package-Manager: Portage-2.3.66, Repoman-2.3.11 mail-mta/netqmail/netqmail-1.06-r6.ebuild | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) Alexander, Yida, I've added a new ebuild revision based on your work. It would be great if the ebuild could be reworked to include Frederik Vermeulen's most recent patches instead, but that looked non-trivial and since I don't use netqmail I'd rather not make changes that are too invasive. (In reply to Hans de Graaff from comment #13) > Alexander, Yida, I've added a new ebuild revision based on your work. It > would be great if the ebuild could be reworked to include Frederik > Vermeulen's most recent patches instead, but that looked non-trivial and > since I don't use netqmail I'd rather not make changes that are too invasive. I just started work on basing the combined tls+auth patch on Vermeulen's most recent patch (20190517) and will create a pull request. I also looked into reworking the ebuild so that Vermeulen's patches could be applied directly by the build process, but this is indeed non-trivial, because they do not apply cleanly anymore on top of the auth patch (http://www.fehcom.de/qmail/smtpauth.html##PATCHES). I have an updated patch now at https://mirror.alexh.name/qmail/netqmail/netqmail-1.05-tls-smtpauth-20190517.patch, however patch qmail-smtputf8.patch fails now. Will add the output as new attachment. Created attachment 589470 [details]
Failed patch on top of updated tls+auth patch
|