Summary: | net-libs/neon-0.30.2[-gnutls,pkcs11,ssl] fails to build with >=dev-libs/openssl-1.1: ne_pkcs11.c:78:23: error: ‘RSA_F_RSA_EAY_PRIVATE_ENCRYPT’ undeclared | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Kenton Groombridge <rustyvega> |
Component: | Current packages | Assignee: | Arfrever Frehtes Taifersar Arahesis <arfrever.fta> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | eva, mail, matthew, proxy-maint |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 592438 | ||
Attachments: | build.log |
Description
Kenton Groombridge
2019-01-04 22:20:56 UTC
Created attachment 559882 [details]
build.log
I've seen this as well. Disabling "pkcs11" use flag fixes; relatively few downstream apps seem to be using this (notably musicbrainz, needed by kdemultimedia) and I haven't seen anything that breaks as a result of disabling pkcs11. Is there a way conditionally mask the use flag based on the openssl version? This code was changed once in a commit (r1974) which said "Add OpenSSL 1.1.0 compatibility": http://lists.manyfish.co.uk/pipermail/neon-commits/2016-September/001037.html +#if defined(RSA_F_RSA_PRIVATE_ENCRYPT) +#define PK11_RSA_ERR (RSA_F_RSA_PRIVATE_ENCRYPT) +#else #define PK11_RSA_ERR (RSA_F_RSA_EAY_PRIVATE_ENCRYPT) +#endif But maybe it was incorrect or only correct for earlier versions of OpenSSL 1.1.0... Neon with USE="gnutls" would not use OpenSSL, so unconditional masking of USE="pkcs11" would be wrong. According to my research, RSA_F_RSA_EAY_PRIVATE_ENCRYPT was renamed to not RSA_F_RSA_PRIVATE_ENCRYPT, but RSA_F_RSA_OSSL_PRIVATE_ENCRYPT. The value remains 102. https://github.com/openssl/openssl/commit/bf1605518a085256320ff4a36054445f842d5c1c "Rename RSA_eay_xxx to rsa_ossl_xxx" To confirm, I can build neon with the pkcs11 flag if I change the macro from RSA_F_RSA_PRIVATE_ENCRYPT to RSA_F_RSA_OSSL_PRIVATE_ENCRYPT. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e0556ce3cbc530d36ba9548aedcac376d545b970 commit e0556ce3cbc530d36ba9548aedcac376d545b970 Author: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org> AuthorDate: 2019-02-23 05:03:10 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2019-02-25 21:24:55 +0000 net-libs/neon: Fix building with USE="-gnutls pkcs11 ssl" and >=dev-libs/openssl-1.1. Fixes: https://bugs.gentoo.org/674554 Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org> Signed-off-by: Mike Gilbert <floppym@gentoo.org> net-libs/neon/neon-0.30.2.ebuild | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) |