Bug 673624

Summary:	emerge sync -q should not log about passing signature verification
Product:	Portage Development	Reporter:	Dirkjan Ochtman (RETIRED) <djc>
Component:	Core	Assignee:	Portage team <dev-portage>
Status:	RESOLVED FIXED
Severity:	normal	CC:	sam
Priority:	Normal	Keywords:	InVCS
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:	911938
Bug Blocks:

Description Dirkjan Ochtman (RETIRED) gentoo-dev

2018-12-23 19:48:22 UTC

When using sync -q, it should probably not write this to stdout (or stderr):

 * Using keys from /usr/share/openpgp-keys/gentoo-release.asc
 * Trusted signature found on top commit

(This started happening when I switched to Git sync with "sync-git-verify-commit-signature = true".)

Comment 1 Larry the Git Cow gentoo-dev

2023-08-19 15:42:54 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=b7abeab6041247a0b5f9d750fb5c85e6f573f90c

commit b7abeab6041247a0b5f9d750fb5c85e6f573f90c
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-08-19 15:38:22 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-08-19 15:38:56 +0000

    sync: git: don't log on OK signature with --quiet
    
    No point in emitting a message if everything is fine when the user asks
    for --quiet.
    
    Bug: https://bugs.gentoo.org/673624
    Signed-off-by: Sam James <sam@gentoo.org>

 NEWS                                | 2 ++
 lib/portage/sync/modules/git/git.py | 4 +++-
 2 files changed, 5 insertions(+), 1 deletion(-)

Comment 2 Larry the Git Cow gentoo-dev

2023-08-20 07:58:32 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a6a68c0255b6d3132dd555b1519a035204bffde2

commit a6a68c0255b6d3132dd555b1519a035204bffde2
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-08-20 07:57:47 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-08-20 07:58:22 +0000

    sys-apps/portage: add 3.0.51
    
    Bug: https://bugs.gentoo.org/587484
    Closes: https://bugs.gentoo.org/673624
    Closes: https://bugs.gentoo.org/691434
    Closes: https://bugs.gentoo.org/835927
    Closes: https://bugs.gentoo.org/909009
    Closes: https://bugs.gentoo.org/911335
    Closes: https://bugs.gentoo.org/911629
    Closes: https://bugs.gentoo.org/911938
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/portage/Manifest              |   1 +
 sys-apps/portage/portage-3.0.51.ebuild | 234 +++++++++++++++++++++++++++++++++
 2 files changed, 235 insertions(+)