Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 673378

Summary: media-libs/gegl-0.2.0-r5 with media-video/ffmpeg-4.1 - ?
Product: Gentoo Linux Reporter: Joakim Tjernlund <joakim.tjernlund>
Component: Current packagesAssignee: Sebastian Pipping <sping>
Status: RESOLVED FIXED    
Severity: normal CC: t-mo
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 686454    
Bug Blocks: 653678    
Attachments: build log
Patch for ffmpeg 4

Description Joakim Tjernlund 2018-12-18 08:32:04 UTC
This little patch makes it build though:
 --- ./operations/external/ff-load.c.org	2018-12-18 09:22:34.467409854 +0100
+++ ./operations/external/ff-load.c	2018-12-18 09:22:50.921379092 +0100
@@ -309,8 +309,8 @@
           g_warning ("codec not found");
         }
 
-      if (p->codec->capabilities & CODEC_CAP_TRUNCATED)
-        p->enc->flags |= CODEC_FLAG_TRUNCATED;
+      if (p->codec->capabilities & AV_CODEC_CAP_TRUNCATED)
+        p->enc->flags |= AV_CODEC_FLAG_TRUNCATED;
 
       if (avcodec_open2 (p->enc, p->codec, NULL) < 0)
         {
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2018-12-18 08:36:29 UTC
If you don't show some output exhibiting the exact problem, that makes bugs harder to distinguish and track. Please attach the entire build log to this bug report.
Comment 2 Joakim Tjernlund 2018-12-18 08:45:25 UTC
Created attachment 558084 [details]
build log
Comment 3 Joakim Tjernlund 2018-12-18 09:30:51 UTC
FYI ffmpeg-3.4.5 also builds with the patch applied.
Comment 4 Joakim Tjernlund 2019-01-02 15:33:26 UTC
Created attachment 559474 [details, diff]
Patch for ffmpeg 4
Comment 5 Winston Weinert 2019-01-28 00:39:51 UTC
(In reply to Joakim Tjernlund from comment #4)
> Created attachment 559474 [details, diff] [details, diff]
> Patch for ffmpeg 4

I did not investigate, but this possibly breaks support for older versions of ffmpeg, might need to include an #ifndef #define ... #endif.
Comment 6 Joakim Tjernlund 2019-01-28 08:11:55 UTC
(In reply to Winston Weinert from comment #5)
> (In reply to Joakim Tjernlund from comment #4)
> > Created attachment 559474 [details, diff] [details, diff] [details, diff]
> > Patch for ffmpeg 4
> 
> I did not investigate, but this possibly breaks support for older versions
> of ffmpeg, might need to include an #ifndef #define ... #endif.

if you care, test the ones you are concerned with. ffmpeg-3.4.5 to be OK though.
Comment 7 Joakim Tjernlund 2019-02-13 15:18:27 UTC
Ping ?

ffmpeg-4.1.1 is in tree now
Comment 8 Joakim Tjernlund 2019-03-09 17:04:12 UTC
yet a ping, this is one of 3 pkgs blocking ffmpeg 4 so nice if this could be sorted out.
Comment 9 Sebastian Pipping gentoo-dev 2019-03-09 18:04:17 UTC
(In reply to Joakim Tjernlund from comment #8)
> yet a ping, this is one of 3 pkgs blocking ffmpeg 4 so nice if this could be
> sorted out.

Hi! You are using stable media-gfx/gimp 2.8.22-r1 and need gegl 0.2 for that , is that right?  Both of these are so old and very likely not secure that I would like to ask if we should rather make a more recent version of gegl and gimp stable than trying resurrect zombie gegl 0.2.  gegl 0.4 is compatible to ffmpeg 4  in Gentoo as of today.  What do you think?
Comment 10 Larry the Git Cow gentoo-dev 2019-03-09 18:22:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c14536acbbaf812c83be04f8db58abb76b04b93f

commit c14536acbbaf812c83be04f8db58abb76b04b93f
Author:     Sebastian Pipping <sping@gentoo.org>
AuthorDate: 2019-03-09 18:21:04 +0000
Commit:     Sebastian Pipping <sping@gentoo.org>
CommitDate: 2019-03-09 18:21:59 +0000

    media-libs/gegl: 0.2 with ffmpeg 4
    
    Closes: https://bugs.gentoo.org/673378
    Signed-off-by: Sebastian Pipping <sping@gentoo.org>
    Package-Manager: Portage-2.3.50, Repoman-2.3.11

 .../gegl/files/gegl-0.2.0-ffmpeg-4-0-compat.patch  |  13 ++
 media-libs/gegl/gegl-0.2.0-r6.ebuild               | 168 +++++++++++++++++++++
 2 files changed, 181 insertions(+)
Comment 11 Joakim Tjernlund 2019-03-10 13:08:52 UTC
(In reply to Sebastian Pipping from comment #9)
> (In reply to Joakim Tjernlund from comment #8)
> > yet a ping, this is one of 3 pkgs blocking ffmpeg 4 so nice if this could be
> > sorted out.
> 
> Hi! You are using stable media-gfx/gimp 2.8.22-r1 and need gegl 0.2 for that
> , is that right?  Both of these are so old and very likely not secure that I
> would like to ask if we should rather make a more recent version of gegl and
> gimp stable than trying resurrect zombie gegl 0.2.  gegl 0.4 is compatible
> to ffmpeg 4  in Gentoo as of today.  What do you think?

I am, moving to a newer gimp is OK for me.