Bug 673168

Summary:	net-fs/samba installs/removes Parse/Yapp/Driver.pm every other time.
Product:	Gentoo Linux	Reporter:	Kent Fredric (IRC: kent\n) (RETIRED) <kentnl>
Component:	Current packages	Assignee:	Gentoo's SAMBA Team <samba>
Status:	RESOLVED OBSOLETE
Severity:	normal	CC:	bkohler
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=562918
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	samba-4.9.3:20181215-092328.log.xz samba-4.9.3:20181215-093240.log.xz

Description Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev

2018-12-15 09:45:23 UTC

Created attachment 557790 [details]
samba-4.9.3:20181215-092328.log.xz

It turns out there's a logic bug in configure:

1. If it can detect an existing copy of Parse/Yapp/Driver.pm, it won't install one.
2. If it doesn't detect one, it will install one.

This means that if you install samba twice:

- The first time it will install a Parse/Yapp/Driver.pm due to it not being there
- The second time, it will detect an existing copy ( from the previous install ), and opt not to install a new one.

Of course, this combination is flawed, because when the second set of samba files gets installed, the first set is removed, and with it, Parse/Yapp/Driver.pm

And this makes bug like bug #562918 extra fun, because only half of the user base could expect to hit this collision!

Iteration 1:

Checking for SHA512_Update                          : not found
Checking for perl module Parse::Yapp::Driver 1.05   : not found
perl manpage generation                             : ok
perl man1 extension                                 : 1
perl man3 extension                                 : 3pm

...


* installing pidl/lib/Parse/Yapp/Driver.pm as /var/tmp/portage/net-fs/samba-4.9.3/image/usr/lib64/perl5/vendor_perl/5.28.0/Parse/Yapp/Driver.pm

...

>>> /usr/lib64/perl5/vendor_perl/5.28.0/Parse/Yapp/
>>> /usr/lib64/perl5/vendor_perl/5.28.0/Parse/Yapp/Driver.pm


Iteration 2:

Checking for SHA512_Update                         : not found
Checking for perl module Parse::Yapp::Driver 1.05  : ok
perl manpage generation                            : ok
perl man1 extension                                : 1
perl man3 extension                                : 3pm

...

--- replaced dir /usr/lib64/pkgconfig
<<<          obj /usr/lib64/perl5/vendor_perl/5.28.0/Parse/Yapp/Driver.pm
--- replaced obj /usr/lib64/perl5/vendor_perl/5.28.0/Parse/Pidl/Wireshark/NDR.pm

...
--- replaced obj /etc/conf.d/samba
--- replaced dir /etc/conf.d
--- replaced dir /etc
<<<          dir /usr/lib64/perl5/vendor_perl/5.28.0/Parse/Yapp
>>> Regenerating /etc/ld.so.cache...

Comment 1 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev

2018-12-15 09:47:15 UTC

Created attachment 557792 [details]
samba-4.9.3:20181215-093240.log.xz

Comment 2 Larry the Git Cow gentoo-dev

2019-07-09 15:50:33 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a9514a13f7283dc4e6f84fcfcb20b524231670d2

commit a9514a13f7283dc4e6f84fcfcb20b524231670d2
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2019-07-09 15:46:28 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2019-07-09 15:50:27 +0000

    net-fs/samba: Bump to version 4.10.6
    
    Don't install Parse/Yapp/Driver.pm
    
    Bug: https://bugs.gentoo.org/673168
    Package-Manager: Portage-2.3.68, Repoman-2.3.16
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 net-fs/samba/Manifest            |   1 +
 net-fs/samba/samba-4.10.6.ebuild | 314 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 315 insertions(+)

Comment 3 Ben Kohler gentoo-dev

2022-07-30 18:08:24 UTC

I don't think this is happening anymore