Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 672422

Summary: x11-base/xorg-drivers-1.20: Move old driver blocks to global mask
Product: Gentoo Linux Reporter: Ben <blc+gentoo>
Component: Current packagesAssignee: Gentoo X packagers <x11>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://forums.gentoo.org/viewtopic-t-1089994.html
Whiteboard:
Package list:
Runtime testing required: ---

Description Ben 2018-12-02 20:56:31 UTC
As suggested by Hu on f.g.o in topic 8287186 and to facilitate easier upgrading, yet still remove the maintenance task from Gentoo developers of old drivers still supported by Xorg, move the blocks that are explicitly written in x11-base/xorg-drivers/xorg-drivers-1.20 into the global package.mask list.

This way people won't be surprised by portage upgrading to an unsupported version without a warning, but easier facilitate upgrades via an overlay.

The drivers in question in x11-base/xorg-drivers/xorg-drivers-1.20.ebuild :

-        !x11-drivers/xf86-input-citron
-        !x11-drivers/xf86-video-apm
-        !x11-drivers/xf86-video-ark
-        !x11-drivers/xf86-video-chips
-        !x11-drivers/xf86-video-cirrus
-        !x11-drivers/xf86-video-cyrix
-        !x11-drivers/xf86-video-i128
-        !x11-drivers/xf86-video-i740
-        !x11-drivers/xf86-video-impact
-        !x11-drivers/xf86-video-mach64
-        !x11-drivers/xf86-video-neomagic
-        !x11-drivers/xf86-video-newport
-        !x11-drivers/xf86-video-nsc
-        !x11-drivers/xf86-video-rendition
-        !x11-drivers/xf86-video-s3
-        !x11-drivers/xf86-video-s3virge
-        !x11-drivers/xf86-video-savage
-        !x11-drivers/xf86-video-sis
-        !x11-drivers/xf86-video-sisusb
-        !x11-drivers/xf86-video-sunbw2
-        !x11-drivers/xf86-video-suncg14
-        !x11-drivers/xf86-video-suncg3
-        !x11-drivers/xf86-video-suncg6
-        !x11-drivers/xf86-video-sunffb
-        !x11-drivers/xf86-video-sunleo
-        !x11-drivers/xf86-video-suntcx
-        !x11-drivers/xf86-video-tga
-        !x11-drivers/xf86-video-trident
-        !x11-drivers/xf86-video-tseng

Then add these to the global package.mask that people can package.unmask override and know that they are dealing with their own overlay:

x11-drivers/xf86-input-citron
x11-drivers/xf86-video-apm
x11-drivers/xf86-video-ark
x11-drivers/xf86-video-chips
x11-drivers/xf86-video-cirrus
x11-drivers/xf86-video-cyrix
x11-drivers/xf86-video-i128
x11-drivers/xf86-video-i740
x11-drivers/xf86-video-impact
x11-drivers/xf86-video-mach64
x11-drivers/xf86-video-neomagic
x11-drivers/xf86-video-newport
x11-drivers/xf86-video-nsc
x11-drivers/xf86-video-rendition
x11-drivers/xf86-video-s3
x11-drivers/xf86-video-s3virge
x11-drivers/xf86-video-savage
x11-drivers/xf86-video-sis
x11-drivers/xf86-video-sisusb
x11-drivers/xf86-video-sunbw2
x11-drivers/xf86-video-suncg14
x11-drivers/xf86-video-suncg3
x11-drivers/xf86-video-suncg6
x11-drivers/xf86-video-sunffb
x11-drivers/xf86-video-sunleo
x11-drivers/xf86-video-suntcx
x11-drivers/xf86-video-tga
x11-drivers/xf86-video-trident
x11-drivers/xf86-video-tseng

I hope this would cover all bases:
- A mask warning for users of these older drivers will show up during upgrade
- Blindly upgrading @world will not break xorg without the above warning
- Users not using these drivers will be mostly unaffected.
- Relieve Gentoo developers of testing/supporting these old drivers
- People still needing these drivers are free to overlay them without needing to  also overlay x11-base/xorg-drivers to remove the blocks.

I don't know of Gentoo policy of leaving packages in package.mask as this would need to be an indefinite/permanent mask.  Seeing there are some really old masks already in package.mask, hopefully a few more isn't a problem.
Comment 1 Matt Turner gentoo-dev 2019-03-16 20:12:44 UTC
Very good idea. Thank you!
Comment 2 Larry the Git Cow gentoo-dev 2019-03-16 20:12:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7e5ca3b3ed08e9e1ae1e30af704edc1c41f196b7

commit 7e5ca3b3ed08e9e1ae1e30af704edc1c41f196b7
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2019-03-16 20:11:53 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2019-03-16 20:12:27 +0000

    x11-base/xorg-drivers: Move removed drivers' blockers to a mask
    
    Closes: https://bugs.gentoo.org/672422
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 profiles/package.mask                          | 34 ++++++++++++++++++++++++++
 x11-base/xorg-drivers/xorg-drivers-1.20.ebuild | 30 -----------------------
 x11-base/xorg-drivers/xorg-drivers-9999.ebuild | 30 -----------------------
 3 files changed, 34 insertions(+), 60 deletions(-)