Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 672194

Summary: net-libs/libwebsockets-2.4.2 - include/../sshd.c:2515:5: error: attempt to free a non-heap object ‘buf’
Product: Gentoo Linux Reporter: Juergen Rose <rose>
Component: Current packagesAssignee: Jaco Kroon <jaco>
Status: RESOLVED FIXED    
Severity: normal CC: proxy-maint, yuchen.xie
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/13579
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: build.log

Description Juergen Rose 2018-11-28 17:04:01 UTC
Created attachment 556606 [details]
build.log

'MAKEOPTS=-j1 emerge -v1 libwebsockets' fails with:
...
make[2]: Leaving directory '/var/tmp/portage/net-libs/libwebsockets-2.4.2/work/libwebsockets-2.4.2_build'
make -f CMakeFiles/test-sshd.dir/build.make CMakeFiles/test-sshd.dir/build
make[2]: Entering directory '/var/tmp/portage/net-libs/libwebsockets-2.4.2/work/libwebsockets-2.4.2_build'
[ 84%] Building C object CMakeFiles/test-sshd.dir/test-apps/test-sshd.c.o
/usr/bin/x86_64-pc-linux-gnu-gcc -DINSTALL_DATADIR=\"/usr/share\" -I/var/tmp/portage/net-libs/libwebsockets-2.4.2/work/libwebsockets-2.4.2_build -I/var/tmp/portage/net-libs/libwebsockets-2.4.2/work/libwebsockets-2.4.2/lib -I/var/tmp/portage/net-libs/libwebsockets-2.4.2/work/libwebsockets-2.4.2/plugins/ssh-base/include   -DNDEBUG -Wall -Werror -fvisibility=hidden -Wundef -march=broadwell -O2 -pipe   -o CMakeFiles/test-sshd.dir/test-apps/test-sshd.c.o -c /var/tmp/portage/net-libs/libwebsockets-2.4.2/work/libwebsockets-2.4.2/test-apps/test-sshd.c
In file included from /var/tmp/portage/net-libs/libwebsockets-2.4.2/work/libwebsockets-2.4.2/plugins/ssh-base/include/lws-plugin-sshd-static-build-includes.h:17,
                 from /var/tmp/portage/net-libs/libwebsockets-2.4.2/work/libwebsockets-2.4.2/test-apps/test-sshd.c:38:
/var/tmp/portage/net-libs/libwebsockets-2.4.2/work/libwebsockets-2.4.2/plugins/ssh-base/include/../sshd.c: In function ‘lws_callback_raw_sshd’:
/var/tmp/portage/net-libs/libwebsockets-2.4.2/work/libwebsockets-2.4.2/plugins/ssh-base/include/../sshd.c:2515:5: error: attempt to free a non-heap object ‘buf’ [-Werror=free-nonheap-object]
     free(ps);
     ^~~~~~~~
cc1: all warnings being treated as errors



root@lynx:/home/rose(87)# emerge --info '=net-libs/libwebsockets-2.4.2::gentoo'
Portage 2.3.52 (python 3.6.6-final-0, default/linux/amd64/17.0/desktop, gcc-8.2.0, glibc-2.28-r2, 4.19.4-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.19.4-gentoo-x86_64-Intel-R-_Core-TM-_i7-6700HQ_CPU_@_2.60GHz-with-gentoo-2.6
KiB Mem:    15904040 total,   8149988 free
KiB Swap:   50331644 total,  49065488 free
Timestamp of repository gentoo: Wed, 28 Nov 2018 08:00:01 +0000
Head commit of repository gentoo: d405727b5e53d33b205f226b8c9bc43d93421be5
sh bash 4.4_p23
ld GNU ld (Gentoo 2.31.1 p3) 2.31.1
distcc[21237] (dcc_trace_version) distcc 3.2rc1 x86_64-pc-linux-gnu; built Nov 27 2018 23:24:05 [disabled]
app-shells/bash:          4.4_p23::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.26.2::gentoo
dev-lang/python:          2.7.15-r100::sage-on-gentoo, 3.6.6::gentoo, 3.7.0::gentoo
dev-util/cmake:           3.11.4-r1::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.11.6-r3::gentoo, 1.13.4-r2::gentoo, 1.15.1-r2::gentoo, 1.16.1-r1::gentoo
sys-devel/binutils:       2.31.1-r1::gentoo
sys-devel/gcc:            8.2.0-r4::gentoo
sys-devel/gcc-config:     2.0::gentoo
sys-devel/libtool:        2.4.6-r5::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 4.19::gentoo (virtual/os-headers)
sys-libs/glibc:           2.28-r2::gentoo
Repositories:

gentoo
    location: /usr/portage_lynx
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-metamanifest: yes
    sync-rsync-extra-opts: 
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-jobs: 1

haskell
    location: /var/lib/layman/haskell
    masters: gentoo
    priority: 0

local
    location: /usr/local/portage
    masters: gentoo
    priority: 1

g-cpan
    location: /var/lib/cpan
    masters: gentoo
    priority: 2

ago
    location: /var/lib/layman/ago
    masters: gentoo
    priority: 50

imaging
    location: /var/lib/layman/imaging
    masters: gentoo
    priority: 50

octave
    location: /var/lib/layman/octave
    masters: gentoo
    priority: 50

sage-on-gentoo
    location: /var/lib/layman/sage-on-gentoo
    masters: gentoo science
    priority: 50

science
    location: /var/lib/layman/science
    masters: gentoo
    priority: 50

tlp
    location: /var/lib/layman/tlp
    masters: gentoo
    priority: 50

torbrowser
    location: /var/lib/layman/torbrowser
    masters: gentoo
    priority: 50

x11
    location: /var/lib/layman/x11
    masters: gentoo
    priority: 50

Installed sets: @system
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA PUEL Intel-SDP dlj-1.1 skype-eula skype-4.0.0.7-copyright googleearth AdobeFlash-11.x cadsoft Oracle-BCLA-JavaSE MakeMKV-EULA NVIDIA-CUDA Nero-AAC-EULA GIMPS"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=broadwell -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /etc/stunnel/stunnel.conf /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php7.2/ext-active/ /etc/php/cgi-php7.2/ext-active/ /etc/php/cli-php7.2/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=broadwell -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs clean-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-march=broadwell -O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="de en fr ru"
MAKEOPTS="-j9"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="64bit R X Xaw3d a52 aac acl acpi admin afs alsa amd64 amr ao apache2 apng applet archive armadillo arpack asf aspell assistant atlas audacious audiofile aufs automap automount barcode bash-completion berkdb blas blast bluetooth bluray boost branding btrfs bzip2 cairo cdda cddb cdf cdio cdparanoia cdr cgi chm cilk clang cli cmake collada consolekit contrib crypt css cups curl cxx daap db dbi dbm dbus declarative designer devhelp device-mapper dga dia digitalradio djvu doc dot dri ds2490 ds9097 ds9097u dts dv dvb dvd dvdr dvi dynamicplugin eds egl elf emacs emboss emf encode epiphany evdev evo examples excel exif expat extensions extra extras faac faad fam ffmpeg fftw firefox fits flac fltk fontconfig foomaticdb fortran fortran95 fpm fpx ftp fuse gcj gd gdal gdbm gedit geoip geolocation geos gfortran gif gimp git glade glamor glib glpk gml gmp gnome gnome-keyring gnuplot gnutls gold gphoto2 gpm grammar graphics graphtft graphviz grass gsl gsm gstreamer gtk gtk3 gudev guile hdaps hddtemp hdf hdf5 hdri html http httpd hvm hwdb iconv icq icu id3tag ide imagemagick imap initramfs inotify introspection ipod ipv6 irda ithreads jadetex java jbig jit john jpeg jpeg2k kate kde kdepim kdrive kerberos keymap kpathsea kvm ladspa lame lapack latex lcms ldap lensfun libffi libgda libkms libnotify libsamplerate libtirpc live lm_sensors lua lzma lzo mad mail maildir mapnik math matroska media-library mercurial mikmod mng mod mono motif mozilla mp3 mp4 mpeg mpi mpi-threads mplayer mtp multilib multimedia musepack musicbrainz mysql mysqli nautilus ncurses neXt netcdf netpbm network networking nfs nls nntp nptl nsplugin ntfs ntp numpy obex objc ocaml ocr octave odbc ofa ogdi ogg opencv openexr opengl openmp openvg pam pango pcre pda pdf pdl2 perl plasma plotutils plugins png podcast policykit portaudio posix postgres postscript ppds ppp preview-latex proj projectm pstricks pulseaudio python q16 q32 qemu qhull qml qt5 quicktime raw readline reiserfs reports rle romio rpc rrdcgi rrdtool rtlsdr sage samba sasl schroedinger science sdk sdl seccomp secure-delete server session shout sip slang slp smart smbclient smp sms sndfile snmp soap sockets sound soup sox speex spell sql sqlite ssl startup-notification stlport subtitles subversion sudo suexec svg svm swig systemd szip t1lib tbb tcl tcpd tex tex4ht theora thesaurus thinkpad threads thunderbird tidy tiff tk tools truetype udev udisks unicode upower usb utempter v4l v4l2 vaapi vala valgrind vdpau video vim-syntax virt-network virtualbox visio vorbis vpx vtk wav wayland webdav webdav-serf webkit wifi wmf wxwidgets x264 x265 xa xattr xcb xen xetex xft xine xml xmlreader xmlrpc xpm xps xv xvid xvmc yaml youtube zlib zsh-completion zvbi" ABI_X86="64" ALSA_CARDS="intel8x0" APACHE2_MODULES="actions alias auth_basic auth_digest authn_anon authn_dbd authn_core authn_dbm authn_default authn_file authz_core authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgid dav dav_fs dav_lock dbd deflate dir disk_cache env expires ext_filter file_cache filter headers ident imagemap include info lbmethod_byrequests log_config logio mem_cache mime mime_magic negotiation proxy proxy_ajp proxy_balancer proxy_connect proxy_http rewrite setenvif slotmem_shm so socache_shmcb speling status unique_id unixd userdir usertrack vhost_alias" APACHE2_MPMS="worker" CALLIGRA_FEATURES="karbon plan sheets stage words" CAMERAS="canon fuji ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog sensors thermal" CPU_FLAGS_X86="aes avx avx2 fma3 mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="aivdm ashtech earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 navcom ntrip oceanserver oncore rtcm104v2 rtcm104v3 sirf superstar2 tnt tripmate tsip ublox nmea0183 nmea2000 passthrough" GRUB_PLATFORMS="emu efi-64 pc xen" INPUT_DEVICES="keyboard mouse evdev synaptics void" KERNEL="linux" L10N="de en fr ru" LCD_DEVICES="cfontz framebuffer glcd hd44780 mtxorb ncurses X lcd2usb lcdlinux png usblcd SureElec" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LIRC_DEVICES="devinput" LLVM_TARGETS="NVPTX X86" NETBEANS_MODULES="apisupport cnd dlight enterprise ergonomics groovy gsf harness ide identity j2ee java mobility nb php profiler websvccommon xml" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-1" POSTGRES_TARGETS="postgres9_5 postgres10" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" QEMU_SOFTMMU_TARGETS="arm i386 x86_64" QEMU_USER_TARGETS="arm i386 x86_64" RUBY_TARGETS="ruby23 ruby24" USERLAND="GNU" VIDEO_CARDS="nouveau displaylink" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

net-libs/libwebsockets-2.4.2::gentoo was built with the following:
USE="access-log cgi client generic-sessions http2 ipv6 lejp libuv server-status smtp sqlite3 ssl zip -caps -http-proxy -libev -libevent -libressl -peer-limits -socks5 -static-libs" ABI_X86="(64)"



root@lynx:/home/rose(88)# emerge -pqv '=net-libs/libwebsockets-2.4.2::gentoo'
[ebuild   R   ] net-libs/libwebsockets-2.4.2  USE="access-log cgi client generic-sessions http2 ipv6 lejp libuv server-status smtp sqlite3 ssl zip -caps -http-proxy -libev -libevent -libressl -peer-limits -socks5 -static-libs"
Comment 1 Juergen Rose 2018-12-29 16:04:43 UTC
See also https://bugs.gentoo.org/674004 .


root@lynx:/usr/local/portage/dev-java/jython(107)# genlop -t openssl | tail

     Tue Nov 13 16:03:33 2018 >>> dev-libs/openssl-1.0.2p-r1
       merge time: 3 minutes and 51 seconds.

     Tue Nov 20 23:55:37 2018 >>> dev-libs/openssl-1.0.2q
       merge time: 3 minutes and 58 seconds.

     Sat Dec 29 02:58:38 2018 >>> dev-libs/openssl-1.1.0j
       merge time: 2 minutes and 35 seconds.

root@lynx:/usr/local/portage/dev-java/jython(108)# qlist -Iv openssl
dev-libs/openssl-1.1.0j
dev-python/pyopenssl-17.5.0
Comment 2 Larry the Git Cow gentoo-dev 2019-11-12 14:45:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=31ceadbd479ef83029bfa47e3315dd713bb584fe

commit 31ceadbd479ef83029bfa47e3315dd713bb584fe
Author:     Jaco Kroon <jaco@uls.co.za>
AuthorDate: 2019-11-07 10:46:17 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2019-11-12 14:45:29 +0000

    net-libs/libwebsockets: version bump to 3.2.0
    
    Closes: https://bugs.gentoo.org/696554
    Closes: https://bugs.gentoo.org/615532
    Closes: https://bugs.gentoo.org/618428
    Closes: https://bugs.gentoo.org/672194
    Closes: https://bugs.gentoo.org/669152
    Package-Manager: Portage-2.3.76, Repoman-2.3.16
    Signed-off-by: Jaco Kroon <jaco@uls.co.za>
    Closes: https://github.com/gentoo/gentoo/pull/13579
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 net-libs/libwebsockets/Manifest                    |  1 +
 .../libwebsockets-3.2.0-check_chown_result.patch   | 22 ++++++
 .../libwebsockets-3.2.0-string_assignment.patch    | 11 +++
 net-libs/libwebsockets/libwebsockets-3.2.0.ebuild  | 80 ++++++++++++++++++++++
 4 files changed, 114 insertions(+)