| Summary: | media-video/ffmpeg-4* missing nvenc use flag | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Craig Andrews <candrews> |
| Component: | Current packages | Assignee: | Gentoo Media-video project <media-video> |
| Status: | RESOLVED INVALID | ||
| Severity: | normal | CC: | candrews |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/10402 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
|
Description
Craig Andrews
2018-11-13 01:50:52 UTC
See: commit 72efc6ce0847d20ebaa7e2f4ceb042d36e97e244 Author: Alexis Ballier <aballier@gentoo.org> Date: Sun Apr 22 12:52:34 2018 +0200 media-video/ffmpeg: rework nvidia codec support Closes: https://bugs.gentoo.org/653378 Closes: https://bugs.gentoo.org/648170 Package-Manager: Portage-2.3.31, Repoman-2.3.9 The nvenc use flag activates nvenc in ffmpeg, see https://github.com/gentoo/gentoo/pull/10402/ The video_cards_nvidia activates for in ffmpeg. Are those two different things? (In reply to Craig Andrews from comment #2) > The nvenc use flag activates nvenc in ffmpeg, see > https://github.com/gentoo/gentoo/pull/10402/ > The video_cards_nvidia activates for in ffmpeg. > > Are those two different things? nvenc is also activated with the video cards settings; nvenc requires video_cards_nvidia to be enabled; there's no point in having 2 useflags here (In reply to Alexis Ballier from comment #3) > (In reply to Craig Andrews from comment #2) > > The nvenc use flag activates nvenc in ffmpeg, see > > https://github.com/gentoo/gentoo/pull/10402/ > > The video_cards_nvidia activates for in ffmpeg. > > > > Are those two different things? > > nvenc is also activated with the video cards settings; nvenc requires > video_cards_nvidia to be enabled; there's no point in having 2 useflags here I think ffnvcodec (which is activated by video_cards_nvidia) is a decoder (as that's what the comment in ffmpeg-4.1.ebuild says it is), while we're talking about an encoder (nvenc). I don't see where in ffmpeg-4.1.ebuild nvenc is enabled (the string "nvenc" doesn't appear in that file). Should there be: video_cards_nvidia:nvenc in FFMPEG_ENCODER_FLAG_MAP? On IRC, Alexis explained: it's not; it's automatic by the configure script So that's that; no need for an nvenc use flag :) (In reply to Craig Andrews from comment #5) > On IRC, Alexis explained: > it's not; it's automatic by the configure script > > So that's that; no need for an nvenc use flag :) I think I must be missing something here? I have an old nvidia card 06:00.0 VGA compatible controller: NVIDIA Corporation GT215 [GeForce GT 240] (rev a2) which requires the 340 series driver and as far as I can tell cannot use ffnvcodec. I have nvenc disabled for ffmpeg 3 series builds. As you say the ffnvcodec is automatically included in the ffmpeg 4 series, however looking at the configure script the following option exists --disable-ffnvcodec therefore I believe the nvenc use flag should be reimplemented to enable this option for older cards. (In reply to barrie backhurst from comment #6) > (In reply to Craig Andrews from comment #5) > > On IRC, Alexis explained: > > it's not; it's automatic by the configure script > > > > So that's that; no need for an nvenc use flag :) > > > I think I must be missing something here? I have an old nvidia card > > 06:00.0 VGA compatible controller: NVIDIA Corporation GT215 [GeForce GT 240] > (rev a2) > > which requires the 340 series driver and as far as I can tell cannot use > ffnvcodec. I have nvenc disabled for ffmpeg 3 series builds. > > As you say the ffnvcodec is automatically included in the ffmpeg 4 series, > however looking at the configure script the following option exists > > --disable-ffnvcodec > > therefore I believe the nvenc use flag should be reimplemented to enable > this option for older cards. just disable video_cards_nvidia on ffmpeg then; that is what controls ffnvcodec; I understand it is annoying for owners of old cards, I find video_cards more understandable than 'ffnvcodec' (In reply to Alexis Ballier from comment #7) > (In reply to barrie backhurst from comment #6) > > (In reply to Craig Andrews from comment #5) > > > On IRC, Alexis explained: > > > it's not; it's automatic by the configure script > > > > > > So that's that; no need for an nvenc use flag :) > > > > > > I think I must be missing something here? I have an old nvidia card > > > > 06:00.0 VGA compatible controller: NVIDIA Corporation GT215 [GeForce GT 240] > > (rev a2) > > > > which requires the 340 series driver and as far as I can tell cannot use > > ffnvcodec. I have nvenc disabled for ffmpeg 3 series builds. > > > > As you say the ffnvcodec is automatically included in the ffmpeg 4 series, > > however looking at the configure script the following option exists > > > > --disable-ffnvcodec > > > > therefore I believe the nvenc use flag should be reimplemented to enable > > this option for older cards. > > just disable video_cards_nvidia on ffmpeg then; that is what controls > ffnvcodec; I understand it is annoying for owners of old cards, I find > video_cards more understandable than 'ffnvcodec' Thanks Alexis, I had assumed that video_cards_nvidia would be more expansive than just controlling ffnvcodec. I can see your point with video_cards_nvidia being more understandable, but equally my instinct was that I had an Nvidia card and therefore video_cards_nvidia should be enabled. I will disable the flag and try updating this evening |