Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 670656

Summary: app-text/cuneiform-1.1.0-r2 with sys-devel/gcc-7.3 - .../work/cuneiform-linux-1.1.0/cuneiform_src/Kern/include/utf8-tables.h:328:1: error: narrowing conversion of ‘130’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
Product: Gentoo Linux Reporter: Andreas Grois <andi>
Component: Current packagesAssignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status: RESOLVED FIXED    
Severity: normal Keywords: NeedPatch, PMASKED
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Andreas Grois 2018-11-08 08:01:01 UTC
The file cuneiform_src/Kern/include/utf8-tables.h includes lots of integer constants, which are smaller than 256 and are being stored in a char array.
The compiler seems not to like this "narrowing" conversion.

An example compile error would be:
/tmp/portage/app-text/cuneiform-1.1.0-r2/work/cuneiform-linux-1.1.0/cuneiform_src/Kern/include/utf8-tables.h:328:1: error: narrowing conversion of ‘130’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]

There are lots of similar errors being output, all with integer constants that are small enough to not be narrowed, but still cause the compiler to complain. That, together with -Werror, causes build failure...
Comment 1 Larry the Git Cow gentoo-dev 2018-11-14 22:32:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a8519bd2c58428d730f61140cd4a843ce68033b3

commit a8519bd2c58428d730f61140cd4a843ce68033b3
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2018-11-14 22:30:33 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2018-11-14 22:32:15 +0000

    app-text/cuneiform: Bugfixes from Fedora
    
    Closes: https://bugs.gentoo.org/421717
    Closes: https://bugs.gentoo.org/595010
    Closes: https://bugs.gentoo.org/670656
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 app-text/cuneiform/cuneiform-1.1.0-r3.ebuild       |  59 +++++++
 .../cuneiform-1.1.0-fix_buffer_overflow.patch      |  27 ++++
 .../cuneiform-1.1.0-fix_buffer_overflow_2.patch    |  18 +++
 .../cuneiform/files/cuneiform-1.1.0-gcc6.patch     | 177 +++++++++++++++++++++
 .../cuneiform/files/cuneiform-1.1.0-gcc7.patch     | 102 ++++++++++++
 .../cuneiform/files/cuneiform-1.1.0-typos.patch    |  54 +++++++
 6 files changed, 437 insertions(+)