Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 670620

Summary: app-emulation/vice-3.1 fails to build against media-video/ffmpeg-4.1
Product: Gentoo Linux Reporter: Adam Jones <adam>
Component: Current packagesAssignee: Gentoo Games <games>
Status: RESOLVED FIXED    
Severity: normal CC: me
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 653678    
Attachments: Patch to build against ffmpeg 4
build.log

Description Adam Jones 2018-11-07 16:56:42 UTC
Created attachment 554436 [details, diff]
Patch to build against ffmpeg 4

With ffmpeg 4 installed, vice fails to build with:

ffmpegdrv.c:970:40: error: ‘AVFMT_RAWPICTURE’ undeclared (first use in this function); did you mean ‘AVFMT_NOFILE’?
     if (ffmpegdrv_oc->oformat->flags & AVFMT_RAWPICTURE) {
                                        ^~~~~~~~~~~~~~~~
                                        AVFMT_NOFILE

A patch is available for this from https://sourceforge.net/p/vice-emu/patches/175/
Comment 1 Adam Jones 2018-11-07 16:57:39 UTC
Created attachment 554438 [details]
build.log
Comment 2 Adam Jones 2018-11-07 16:59:31 UTC
The attached patch works when applied via epatch (saved in /etc/portage/patches/app-emulation/vice-3.1/xxxx.patch)
Comment 3 Chris Faulkner 2018-11-12 00:59:06 UTC
(In reply to Adam Jones from comment #2)
> The attached patch works when applied via epatch (saved in
> /etc/portage/patches/app-emulation/vice-3.1/xxxx.patch)

Patch didn't work for me

 * Applying patch-src_gfxoutputdrv_ffmpegdrv.c.diff ...
The text leading up to this was:
--------------------------
|--- src/gfxoutputdrv/ffmpegdrv.c.orig  2017-03-30 20:32:40 UTC
|+++ src/gfxoutputdrv/ffmpegdrv.c
--------------------------
No file to patch.  Skipping patch.
5 out of 5 hunks ignored                                                                                                                                         [ !! ]
 * ERROR: app-emulation/vice-3.1::gentoo failed (prepare phase):
 *   patch -p1  failed with /etc/portage/patches/app-emulation/vice-3.1/patch-src_gfxoutputdrv_ffmpegdrv.c.diff
Comment 4 Larry the Git Cow gentoo-dev 2018-11-29 22:04:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1b6961ef0347393ca69eb7e03a3cc07d316d36b2

commit 1b6961ef0347393ca69eb7e03a3cc07d316d36b2
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-11-29 21:46:13 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-11-29 22:04:19 +0000

    app-emulation/vice: Fix build with ffmpeg-4
    
    Rename PATCH to PATCHES (again!) and restore missing patch.
    
    Thanks-to: Adam Jones <adam@eidolon.org.uk>
    Closes: https://bugs.gentoo.org/670620
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../vice/files/vice-2.4.27-autotools.patch         | 11 ++++
 app-emulation/vice/files/vice-3.1-ffmpeg4.patch    | 74 ++++++++++++++++++++++
 app-emulation/vice/vice-3.1.ebuild                 |  7 +-
 3 files changed, 89 insertions(+), 3 deletions(-)