| Summary: | net-print/cups-filters with >=app-text/poppler-0.71.0: filter/pdftoraster.cxx:1689:45: error: invalid conversion from ‘const PDFRectangle*’ to ‘PDFRectangle*’ [-fpermissive] PDFRectangle *mediaBox = page->getMediaBox(); | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Lars Wendler (Polynomial-C) (RETIRED) <polynomial-c> |
| Component: | Current packages | Assignee: | Printing Team <printing> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | volkov |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://github.com/OpenPrinting/cups-filters/commit/6b0747c1630dd973acd138f927dbded4ea45e360 | ||
| See Also: | https://github.com/OpenPrinting/cups-filters/issues/69 | ||
| Whiteboard: | fixed in 1.21.6 | ||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 674814 | ||
| Bug Blocks: | 670222 | ||
| Attachments: |
build.log
cups-filters-poppler-0.71.patch |
||
Upstream commit caused this errors https://cgit.freedesktop.org/poppler/poppler/commit/?id=163420b48bdddf9084208b3cadf04dafad52d40a GBool, gTrue, and gFalse replaced by bool, true, false, respectively (poppler-0.71.0) Fix for cups-filters-1.21.3. https://git.archlinux.org/svntogit/packages.git/plain/trunk/cups-filters-poppler-0.71.patch?h=packages/cups-filters&id=12a11ed2bd0aac9460bae4ce2390003c0a20ef75 Whole replacement for GBool, gTrue, gFalse Fix for more errors:
filter/pdftoraster.cxx:2169:11: error: 'memCheck' is not a member of 'Object'
Object::memCheck(stderr);
^~~~~~~~
filter/pdftoraster.cxx:2170:3: error: 'gMemReport' was not declared in this scope
gMemReport(stderr);
^~~~~~~~~~
>=app-text/poppler-0.69 support
Upstream commit
https://github.com/OpenPrinting/cups-filters/commit/6b0747c1630dd973acd138f927dbded4ea45e360.patch
Created attachment 554708 [details, diff]
cups-filters-poppler-0.71.patch
Fix errors with the const pointers (poppler-0.71.0)
filter/pdftoijs.cxx: In function 'int main(int, char**)':
filter/pdftoijs.cxx:299:20: error: invalid conversion from 'void (*)(void*, ErrorCategory, Goffset, char*)' {aka 'void (*)(void*, ErrorCategory, long long int, char*)'} to 'void (*)(void*, ErrorCategory, Goffset, const char*)' {aka 'void (*)(void*, ErrorCategory, long long int, const char*)'} [-fpermissive]
setErrorCallback(::myErrorFun,NULL);
^~
filter/pdftoraster.cxx: In function 'void outPage(PDFDoc*, Catalog*, int, SplashOutputDev*, cups_raster_t*)':
filter/pdftoraster.cxx:1689:45: error: invalid conversion from 'const PDFRectangle*' to 'PDFRectangle*' [-fpermissive]
PDFRectangle *mediaBox = page->getMediaBox();
~~~~~~~~~~~~~~~~~^~
filter/pdftoraster.cxx: In function 'int main(int, char**)':
filter/pdftoraster.cxx:1970:20: error: invalid conversion from 'void (*)(void*, ErrorCategory, Goffset, char*)' {aka 'void (*)(void*, ErrorCategory, long long int, char*)'} to 'void (*)(void*, ErrorCategory, Goffset, const char*)' {aka 'void (*)(void*, ErrorCategory, long long int, const char*)'} [-fpermissive]
setErrorCallback(::myErrorFun,NULL);
^~
My last patch should be renamed to cups-filters-poppler-0.70.patch as it is addressed to poppler-0.70 changes. The new upstream version cups-filters 1.21.5 lists poppler fixes in the changelog, it's already in the tree so I believe unless there are any blockers stabilizing this version should resolve this bug. Indeed, and 1.21.6 built fine against 0.72.0 already. |
Created attachment 554344 [details] build.log x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I/usr/include/libpng16 -I/usr/include/poppler -I./cupsfilters/ -march=native -mtune=native -O2 -pipe -std=c++11 -Wall -D_GNU_SOURCE -c -o pdftoraster-pdftoraster.o `test -f 'filter/pdftoraster.cxx' || echo './'`filter/pdftoraster.cxx filter/pdftoraster.cxx: In function ‘void outPage(PDFDoc*, Catalog*, int, SplashOutputDev*, cups_raster_t*)’: filter/pdftoraster.cxx:1689:45: error: invalid conversion from ‘const PDFRectangle*’ to ‘PDFRectangle*’ [-fpermissive] PDFRectangle *mediaBox = page->getMediaBox(); ~~~~~~~~~~~~~~~~~^~ filter/pdftoraster.cxx:1817:6: error: ‘gTrue’ was not declared in this scope gTrue,gTrue,gTrue); ^~~~~ filter/pdftoraster.cxx:1817:6: note: suggested alternative: ‘gfree’ gTrue,gTrue,gTrue); ^~~~~ gfree filter/pdftoraster.cxx: In function ‘int main(int, char**)’: filter/pdftoraster.cxx:1970:20: error: invalid conversion from ‘void (*)(void*, ErrorCategory, Goffset, char*)’ {aka ‘void (*)(void*, ErrorCategory, long long int, char*)’} to ‘void (*)(void*, ErrorCategory, Goffset, const char*)’ {aka ‘void (*)(void*, ErrorCategory, long long int, const char*)’} [-fpermissive] setErrorCallback(::myErrorFun,NULL); ^~ In file included from /usr/include/poppler/Object.h:45, from filter/pdftoraster.cxx:44: /usr/include/poppler/Error.h:50:37: note: initializing argument 1 of ‘void setErrorCallback(void (*)(void*, ErrorCategory, Goffset, const char*), void*)’ extern void setErrorCallback(void (*cbk)(void *data, ErrorCategory category, ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Goffset pos, const char *msg), ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ filter/pdftoraster.cxx:2127:5: error: ‘gFalse’ was not declared in this scope gFalse,paperColor,gTrue ^~~~~~ filter/pdftoraster.cxx:2127:5: note: suggested alternative: ‘pause’ gFalse,paperColor,gTrue ^~~~~~ pause filter/pdftoraster.cxx:2127:23: error: ‘gTrue’ was not declared in this scope gFalse,paperColor,gTrue ^~~~~ filter/pdftoraster.cxx:2127:23: note: suggested alternative: ‘gfree’ gFalse,paperColor,gTrue ^~~~~ gfree filter/pdftoraster.cxx:2166:11: error: ‘memCheck’ is not a member of ‘Object’ Object::memCheck(stderr); ^~~~~~~~ filter/pdftoraster.cxx:2167:3: error: ‘gMemReport’ was not declared in this scope gMemReport(stderr); ^~~~~~~~~~ filter/pdftoraster.cxx:2167:3: note: suggested alternative: ‘rresvport’ gMemReport(stderr); ^~~~~~~~~~ rresvport make[1]: *** [Makefile:4367: pdftoraster-pdftoraster.o] Error 1 make[1]: Leaving directory '/var/tmp/portage/net-print/cups-filters-1.21.3/work/cups-filters-1.21.3' make: *** [Makefile:2077: all] Error 2 * ERROR: net-print/cups-filters-1.21.3::gentoo failed (compile phase): * emake failed