Bug 669892

Summary:	dev-libs/libgit2-0.26.8: test offline (buf::oom::grow) fails
Product:	Gentoo Linux	Reporter:	Thomas Deutschmann (RETIRED) <whissi>
Component:	Current packages	Assignee:	Michał Górny <mgorny>
Status:	RESOLVED FIXED
Severity:	normal	CC:	gnome
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/libgit2/libgit2/issues/4868
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	669736
Attachments:	build.log

Description Thomas Deutschmann (RETIRED) gentoo-dev

2018-10-28 21:10:28 UTC

Created attachment 553566 [details]
build.log

>   1) Failure:
> buf::oom::grow [/var/tmp/portage/dev-libs/libgit2-0.26.8/work/libgit2-0.26.8/tests/buf/oom.c:39]
>   Expression is not true: git_buf_grow(&buf, 0x0fffffff) == -1
> 
> 
> 
> 0% tests passed, 1 tests failed out of 1
> 
> Total Test time (real) = 114.43 sec
> 
> The following tests FAILED:
>           1 - offline (Failed)
> Errors while running CTest
>  * ERROR: dev-libs/libgit2-0

This is a regression. Test passes in libgit2-0.26.7.
Tried 3 times, failed 3 times.
Same test is still failing in latest libgit2-0.27.7.



Portage 2.3.49 (python 3.6.5-final-0, default/linux/x86/17.0, gcc-7.3.0, glibc-2.27-r6, 4.14.65-gentoo i686)
=================================================================
System uname: Linux-4.14.65-gentoo-i686-Intel-R-_Core-TM-_i7-3770K_CPU_@_3.50GHz-with-gentoo-2.4.1
KiB Mem:     3107592 total,    572384 free
KiB Swap:     488276 total,    488276 free
Timestamp of repository gentoo: Sun, 28 Oct 2018 11:44:32 +0000
Head commit of repository gentoo: 23c0e0a6807c79598472d8c3348119e20b54ab58

sh bash 4.4_p12
ld GNU ld (Gentoo 2.30 p5) 2.30.0
app-shells/bash:          4.4_p12::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.24.3-r1::gentoo
dev-lang/python:          2.7.15::gentoo, 3.6.5::gentoo
dev-util/cmake:           3.9.6::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.4.1-r2::gentoo
sys-apps/openrc:          0.38.3::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.15.1-r2::gentoo
sys-devel/binutils:       2.30-r4::gentoo
sys-devel/gcc:            7.3.0-r3::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 4.13::gentoo (virtual/os-headers)
sys-libs/glibc:           2.27-r6::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000

ABI="x86"
ABI_X86="32"
ACCEPT_KEYWORDS="x86"
ACCEPT_LICENSE="* -@EULA"
ACCEPT_PROPERTIES="*"
ACCEPT_RESTRICT="*"
ARCH="x86"
BROOT=""
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=pentium4m -mtune=pentium4m"
CHOST="i686-pc-linux-gnu"
CHOST_x86="i686-pc-linux-gnu"
COLLISION_IGNORE="/lib/modules/*"
CONFIG_PROTECT="/etc /etc/omega.conf /usr/share/config /usr/share/gnupg/qualified.txt"
CPU_FLAGS_X86="mmx mmxext sse sse2"
CXXFLAGS="-O2 -pipe -march=pentium4m -mtune=pentium4m"
DEFAULT_ABI="x86"
EDITOR="/usr/bin/mcedit"
ELIBC="glibc"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
EPREFIX=""
EROOT="/"
ESYSROOT="/"
FCFLAGS="-O2 -march=i686 -pipe"
FEATURES="assume-digests binpkg-logs cgroup config-protect-if-modified distlocks downgrade-backup ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -march=i686 -pipe"
GCC_SPECS=""
GRUB_PLATFORMS="efi-32 pc"
GSETTINGS_BACKEND="dconf"
HOME="/root"
INFOPATH="/usr/share/gcc-data/i686-pc-linux-gnu/7.3.0/info:/usr/share/binutils-data/i686-pc-linux-gnu/2.30/info:/usr/share/info"
INPUT_DEVICES="libinput keyboard mouse"
IUSE_IMPLICIT="abi_x86_32 prefix prefix-chain prefix-guest"
JAVAC="/etc/java-config-2/current-system-vm/bin/javac"
JAVA_HOME="/etc/java-config-2/current-system-vm"
JDK_HOME="/etc/java-config-2/current-system-vm"
KERNEL="linux"
L10N="en en-US de de-DE"
LANG="en_US.UTF-8"
LC_ALL="en_US.UTF-8"
LC_MESSAGES="C"
LC_PAPER="de_DE.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LIBDIR_x86="lib"
LINGUAS="en de"
LOGNAME="root"
MAIL="/var/mail/root"
MAKEOPTS="--jobs 5 --load-average 7.95"
MULTILIB_ABIS="x86"
NOCOLOR="true"
OFFICE_IMPLEMENTATION="libreoffice"
OPENCL_PROFILE="mesa"
OPENGL_PROFILE="xorg-x11"
PAGER="/usr/bin/less"
PATH="/usr/i686-pc-linux-gnu/gcc-bin/7.3.0:/usr/lib/llvm/6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin"
PHP_TARGETS="php5-6 php7-0 php7-1"
POSTGRES_TARGETS="postgres9_5 postgres10"
PWD="/root"
PYTHONDONTWRITEBYTECODE="1"
PYTHON_SINGLE_TARGET="python3_6"
PYTHON_TARGETS="python2_7 python3_6"
QT_GRAPHICSSYSTEM="raster"
ROOT="/"
ROOTPATH="/usr/i686-pc-linux-gnu/gcc-bin/7.3.0:/usr/lib/llvm/6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin"
RUBY_TARGETS="ruby22 ruby23"
SHELL="/bin/bash"
SHLVL="2"
SSH_TTY="/dev/pts/0"
SYSROOT="/"
TERM="tmux-256color"
TMUX="/tmp//tmux-0/default,5393,0"
TMUX_PANE="%5"
TWISTED_DISABLE_WRITING_OF_PLUGIN_CACHE="1"
USER="root"
USERLAND="GNU"
VIDEO_CARDS="vmware"
XDG_CONFIG_DIRS="/etc/xdg"
XDG_DATA_DIRS="/usr/local/share:/usr/share"

Comment 1 Michał Górny archtester

2018-10-28 21:30:56 UTC

@Whissi, could you test whether the following patch fixes it for you:

https://github.com/libgit2/libgit2/commit/415a8ae9c9b6ac18f0524b6af8e58408b426457d.patch

?

Comment 2 Michał Górny archtester

2018-10-28 21:32:09 UTC

Actually, I think it's obvious enough that I'll apply it immediately, and let you stabilize if it solves all the issues.

Comment 3 Thomas Deutschmann (RETIRED) gentoo-dev

2018-10-28 21:36:48 UTC

(In reply to Michał Górny from comment #2)
> Actually, I think it's obvious enough that I'll apply it immediately, and
> let you stabilize if it solves all the issues.

Patch doesn't apply:

> 1 out of 3 hunks FAILED -- saving rejects to file tests/buf/oom.c.rej                                            

...but when upstream propose to release new version without that test because backport impossible, I can stabilize and ignore test failure for now.

Comment 4 Michał Górny archtester

2018-10-28 21:41:25 UTC

No need to, I've already rebased it and when I finish testing it didn't break amd64, I'll commit it.

Comment 5 Larry the Git Cow gentoo-dev

2018-10-28 21:44:19 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=99914da67e748f4eceec5a02e9ce603917d50004

commit 99914da67e748f4eceec5a02e9ce603917d50004
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2018-10-28 21:40:28 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-10-28 21:44:11 +0000

    dev-libs/libgit2: Skip OOM tests on 32-bit systems
    
    Closes: https://bugs.gentoo.org/669892
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 ...libgit2-0.26.8-disable-oom-tests-on-32bit.patch | 64 ++++++++++++++++++++++
 dev-libs/libgit2/libgit2-0.26.8.ebuild             |  7 +++
 dev-libs/libgit2/libgit2-0.27.7.ebuild             |  7 +++
 3 files changed, 78 insertions(+)