Bug 669320

Summary:	Ebuild for gtk+-3.* re. eautoreconf
Product:	Gentoo Linux	Reporter:	Don O <japhack>
Component:	Current packages	Assignee:	Gentoo Linux Gnome Desktop Team <gnome>
Status:	RESOLVED FIXED
Severity:	normal	CC:	martin.cibule
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	log showing order of patch and autoconf

Description Don O 2018-10-22 16:28:43 UTC

Created attachment 552262 [details]
log showing order of patch and autoconf

I'm trying to work on a user patch instead of https://bugs.gentoo.org/669234 (also by me) and I ran into a problem.

I was modifying the configure.ac file and eautoconf/eautoreconf is being called before the user patch is applied. 

And there's this from the forum https://forums.gentoo.org/viewtopic-p-8273774.html#8273774

If I can get the ebuild to properly handle adding a user patch to configure.ac and autoconfig afterwards, then there's no need to modify the ebuild to add the atk-bridge stuff (from linked bug)

Comment 1 Larry the Git Cow gentoo-dev

2018-10-22 23:23:15 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f553f8d6c7d5fe958a7a1fe7f7038863ec71f57d

commit f553f8d6c7d5fe958a7a1fe7f7038863ec71f57d
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2018-10-22 23:22:02 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2018-10-22 23:22:02 +0000

    x11-libs/gtk+: support configure.ac touching user patches
    
    Use GNOME2_EAUTORECONF, which is more correct either way, as it
    avoids a double elibtoolize call (which could lead to subtle
    problems on some more exotic systems or just a QA warning).
    
    Closes: https://bugs.gentoo.org/669320
    Signed-off-by: Mart Raudsepp <leio@gentoo.org>
    Package-Manager: Portage-2.3.49, Repoman-2.3.11

 x11-libs/gtk+/gtk+-3.24.1.ebuild | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comment 2 Don O 2018-10-23 11:15:37 UTC

I modified gtk+-3.22.30 (in my local) the same as 3.24.1 and it works.
The user patch applied clean to configure.ac and was cleanly applied.

Thanks.

Can the same be done to at least the last stable which is gtk+-3.22.30?

There are a few others (that I know of) that would like to not have to modify and keep track of a local ebuild if they don't need to.

And thanks again, for the quick reply and fix.

Comment 3 Mart Raudsepp gentoo-dev

2018-10-23 11:21:11 UTC

No, I don't intend to touch a stable ebuild. I suggest using 3.24.1. I should look into stabilizing it soon, too.

Comment 4 Don O 2018-10-23 11:57:56 UTC

If you're going to stabilize it soon, that's fine.

thanks for the work and replies.