Bug 668660

Summary:	app-admin/procinfo-ng has a wrong Makefile organized, CFLAGS must be substituted by CXXFLAGS
Product:	Gentoo Linux	Reporter:	Denis Pronin <dannftk>
Component:	Current packages	Assignee:	Gentoo Shell Tools project <shell-tools>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jstein
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Denis Pronin 2018-10-14 20:01:31 UTC

There is Makefile.in where CFLAGS is used, in particular in the target

procinfo: procinfo.cpp \
interrupts.cpp diskStats.cpp rendercpupagestat.cpp getmeminfo.cpp \
linux26_procstat.cpp linux26_rendercpupagestat.cpp linux26_netstat.cpp \
cygwin_procstat.cpp cygwin_rendercpupagestat.cpp \
lib/routines.cpp lib/timeRoutines.cpp lib/prettyPrint.cpp \
Makefile
	$(CXX) $(CFLAGS) $(LDFLAGS) procinfo.cpp -o $@ $(LIBS)


CFLAGS must be substituted by CXXFLAGS as CXX compiler is used

Comment 1 Denis Pronin 2018-10-14 20:23:34 UTC

In order to continue, CFLAGS must be substituted by CXXFLAGS not only through the whole file Makefile.in but also in configure.in and then regenerate 'configure' file by the command 'autoconf --force configure.in > configure'

Comment 2 Larry the Git Cow gentoo-dev

2020-03-08 12:37:37 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b1b6e4a46931c0998199aae07b6b3cc73db730b2

commit b1b6e4a46931c0998199aae07b6b3cc73db730b2
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2020-03-08 12:37:21 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2020-03-08 12:37:21 +0000

    app-admin/procinfo-ng: Port to EAPI 7
    
    * Use CXXFLAGS instead of CFLAGS for .cpp files
    * Use proper Autoconf macros for ncurses
    * Unify patches
    
    Closes: https://bugs.gentoo.org/668660
    Closes: https://github.com/gentoo/gentoo/pull/14635
    Package-Manager: Portage-2.3.93, Repoman-2.3.20
    Suggested-by: Denis Pronin <dannftk@yandex.ru>
    Signed-off-by: David Seifert <soap@gentoo.org>

 .../files/procinfo-ng-2.0.304-as-needed.patch      | 11 ----
 .../files/procinfo-ng-2.0.304-autotools.patch      | 69 ++++++++++++++++++++++
 .../files/procinfo-ng-2.0.304-man.patch            |  4 +-
 .../procinfo-ng/procinfo-ng-2.0.304-r1.ebuild      | 25 +++-----
 4 files changed, 79 insertions(+), 30 deletions(-)