| Summary: | media-video/obs-studio: should not call python-single-r1_pkg_setup without USE=python | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Jonathan Callen (RETIRED) <jcallen> |
| Component: | Current packages | Assignee: | Chiitoo <chiitoo> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Keywords: | PullRequest |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/10109 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
Thanks for the report, and apologies for the delayed response! Managed to completely miss this. Will fix. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=eaa7a6fa3c2e601462c7c19f4e81257e3a58557b commit eaa7a6fa3c2e601462c7c19f4e81257e3a58557b Author: Jimi Huotari <chiitoo@gentoo.org> AuthorDate: 2018-10-08 19:06:42 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2018-10-09 10:01:51 +0000 media-video/obs-studio: fix building without Python targets Only call 'python-single-r1_pkg_setup' if USE="python" is set, since without supported Python targets, things will go bad even if USE="-python" is being used. Closes: https://bugs.gentoo.org/667896 Signed-off-by: Jimi Huotari <chiitoo@gentoo.org> Package-Manager: Portage-2.3.50, Repoman-2.3.11 Closes: https://github.com/gentoo/gentoo/pull/10109 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> media-video/obs-studio/obs-studio-21.1.2.ebuild | 6 +++++- media-video/obs-studio/obs-studio-22.0.3.ebuild | 6 +++++- media-video/obs-studio/obs-studio-9999.ebuild | 6 +++++- 3 files changed, 15 insertions(+), 3 deletions(-) |
Even though REQUIRED_USE states "python? ( ${PYTHON_REQUIRED_USE} )", python-single-r1_pkg_setup is being called unconditionally in pkg_setup. This causes the build to fail when no PYTHON_SINGLE_TARGET supported by the ebuild is set. The simplest fix would be to add the following to the ebuild: pkg_setup() { use python && python-single-r1_pkg_setup }