Summary: | www-client/torbrowser-60.2.1_p802 missing "||die" many times | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Jonas Stein <jstein> |
Component: | Overlays | Assignee: | poncho <poncho> |
Status: | RESOLVED UPSTREAM | ||
Severity: | normal | CC: | jstein, poncho |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Jonas Stein
2018-10-03 18:55:29 UTC
Can you point me to some line numbers where "|| die" is missing? I honestly cant find where they should be added... You can link to line numbers on github: https://github.com/MeisterP/torbrowser-overlay/blob/master/www-client/torbrowser/torbrowser-60.2.1_p802.ebuild#L1 https://devmanual.gentoo.org/ebuild-writing/eapi/ "utilities die on their own, unless the nonfatal command is used" But you need ||die for all others like echo, sed... https://github.com/MeisterP/torbrowser-overlay/blob/master/www-client/torbrowser/torbrowser-60.2.1_p802.ebuild#L191 and many more. Well, I'm basically mirroring the firefox ebuild. Apparently including the missing die. https://gitweb.gentoo.org/repo/gentoo.git/tree/www-client/firefox/firefox-60.2.2.ebuild#n247 |