Bug 667668

Summary:	media-sound/clementine: fails to build with =dev-libs/crypto++-7.0.0[-asm]
Product:	Gentoo Linux	Reporter:	Bastien Armand <armand.bastien>
Component:	Current packages	Assignee:	Lars Wendler (Polynomial-C) (RETIRED) <polynomial-c>
Status:	RESOLVED FIXED
Severity:	normal	CC:	alexander, sam, sound
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:	669288
Bug Blocks:

Description Bastien Armand 2018-10-03 18:19:21 UTC

Hi,

When compiling clementine (all versions) with dev-libs/crypto++-7.0.0 (asm use flag is disabled), linking will fail with the following error:
libclementine_lib.a(spotifyblobdownloader.cpp.o): In function `SpotifyBlobDownloader::CheckSignature(QMap<QString, QByteArray> const&, QStringList const&)':
spotifyblobdownloader.cpp:(.text+0x1cdf): undefined reference to `CryptoPP::AlignedDeallocate(void*)'

On crypto++ without asm, only CryptoPP::UnalignedDeallocate exists. This could be due to an error in the header files installed by crypto++ (CRYPTOPP_DISABLE_ASM seems to be correct in config.h though).

The compilation is ok when enabling the asm flag on crypto++.

This is quite similar to #654572.

Regards.

Comment 1 Alexander Tsoy 2018-10-22 09:19:55 UTC

This looks like a bug in `dev-libs/crypto++-7.0.0-r2`. crypto++ ebuild should modify config.h instead of appending `-DCRYPTOPP_DISABLE_ASM` to `CFLAGS`.

Related issue: https://github.com/gentoo/gentoo/pull/10186

Comment 2 Larry the Git Cow gentoo-dev

2018-10-22 09:28:41 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8a3f819fef5aa62abc49ab662b5d2e5d9ae3d010

commit 8a3f819fef5aa62abc49ab662b5d2e5d9ae3d010
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2018-10-22 09:28:32 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2018-10-22 09:28:32 +0000

    media-sound/clementine: Depend on dev-libs/crypto++[asm]
    
    until a better fix has been found.
    
    Bug: https://bugs.gentoo.org/667668
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 media-sound/clementine/clementine-1.3.1_p20180416.ebuild | 4 ++--
 media-sound/clementine/clementine-1.3.1_p20180523.ebuild | 4 ++--
 media-sound/clementine/clementine-9999.ebuild            | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

Comment 3 Alexander Tsoy 2018-10-22 09:35:28 UTC

(In reply to Alexander Tsoy from comment #1)
I filed bug 669288

Comment 4 Alexander Tsoy 2018-10-25 08:02:27 UTC

Please retest with dev-libs/crypto++-7.0.0-r3

Comment 5 Bastien Armand 2018-11-04 16:45:27 UTC

It's ok with dev-libs/crypto++-7.0.0-r3 without the asm flag (but I will keep it enabled).

Thanks for the fixes !