Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 667378

Summary: sys-apps/portage: add QA_INSTALL_PATHS ebuild variable to exempt paths in bin/install-qa-check.d/08gentoo-paths
Product: Portage Development Reporter: Zac Medico <zmedico>
Component: Core - Ebuild SupportAssignee: Portage team <dev-portage>
Status: RESOLVED FIXED    
Severity: normal Keywords: PATCH
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=667280
https://bugs.gentoo.org/show_bug.cgi?id=667604
Whiteboard:
Package list:
Runtime testing required: ---

Description Zac Medico gentoo-dev 2018-09-30 14:07:19 UTC
For bug 667280, there's a desire to exempt qt packages for this eqawarn message:

> QA: other
> The ebuild is installing to one or more unexpected paths:
> 
>   /usr/share/doc/qt-5.11.1
> 
> Please fix the ebuild to use correct FHS/Gentoo policy paths.

We can solve this by introducing a new QA_INSTALL_PATHS ebuild variable, and corresponding QA_STRICT_INSTALL_PATHS make.conf variable. Here are some man page changes for the new variables:

diff --git a/man/ebuild.5 b/man/ebuild.5
index 9f491dd73..65c7fc753 100644
--- a/man/ebuild.5
+++ b/man/ebuild.5
@@ -793,0 +794,7 @@ CFLAGS, CXXFLAGS, FFLAGS, FCFLAGS, and LDFLAGS variables.
+.B QA_INSTALL_PATHS
+This should contain a list of file paths, relative to the image directory, of
+files that are exempt from QA notices regarding ebuilds that install files
+to unusual locations.
+The paths may contain regular expressions with escape\-quoted special
+characters.
+.TP
diff --git a/man/make.conf.5 b/man/make.conf.5
index a33929143..d97d83767 100644
--- a/man/make.conf.5
+++ b/man/make.conf.5
@@ -1062,0 +1063,4 @@ settings from ebuilds.  See also \fBebuild\fR(5).
+\fBQA_STRICT_INSTALL_PATHS = \fI"set"\fR
+Set this to cause portage to ignore any \fIQA_INSTALL_PATHS\fR override
+settings from ebuilds.  See also \fBebuild\fR(5).
+.TP
Comment 2 Larry the Git Cow gentoo-dev 2018-10-06 01:15:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=dd605b1aa574fc035d3319d954be1ca0d2cdde19

commit dd605b1aa574fc035d3319d954be1ca0d2cdde19
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2018-10-06 01:11:02 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2018-10-06 01:14:14 +0000

    Revert "install-qa-checks.d: Add a check for Gentoo path policies (FHS-y)"
    
    This reverts commit d5f97eaa464736a454c8ad410f4acd4fccdf2324.
    Until this QA check has adjustable whitelist support, we can consider
    it an unstable work in progress. Therefore, I'd like for the QA team
    to move it gentoo/metadata/install-qa-check.d/08gentoo-paths until
    it has matured. It's safe to commit it to the gentoo repository now,
    and it will become active when portage's internal copy is removed.
    
    Bug: https://bugs.gentoo.org/667604
    Closes: https://bugs.gentoo.org/667378
    Closes: https://github.com/gentoo/portage/pull/373
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 bin/install-qa-check.d/08gentoo-paths | 77 -----------------------------------
 1 file changed, 77 deletions(-)