| Summary: | app-admin/keepassxc should RDEPEND on x11-misc/xsel | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | flasch <jpflasch> |
| Component: | Current packages | Assignee: | Lars Wendler (Polynomial-C) (RETIRED) <polynomial-c> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | arthur |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | AMD64 | ||
| OS: | Linux | ||
| See Also: |
https://bugs.gentoo.org/show_bug.cgi?id=679726 https://bugs.gentoo.org/show_bug.cgi?id=707692 |
||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
|
Description
flasch
2018-09-25 22:36:38 UTC
My concern with adding this to RDEPEND is that the build system neither checks for its presence nor does the package link to xsel at all even if it is present at compile time. So this is not really a package that is necessary to _run_ keepassxc. I understand your argument and I agree that we should solve this somehow. I'm just not convinced that the RDEPEND approach is the best solution here. Without xsel the Keepassxc will not work with the cut and paste buffer of X11, there is very little doc that will indicate this problem is with xsel not being installed . Yes Keeppassxc is functional without, but a major function of the package is to put userid/passwords into you past/cut buffer so that you can put them into web sites . There is a lot of logic in Keepassxc to interact with the past/cut buffer. Without xsel it just will not work. Yes the makers of Keeppassxc should advertise this problem with xsel not being installed but they don't , they should give errors but they don't. It all gets fixed when you install xsel . I do see you point but it would be better to make sure xsel is installed or get the Keepassxc people to give a error when the cut/paste operations fail. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7217602014591e4fe9b787c32a3c22aed82ee919 commit 7217602014591e4fe9b787c32a3c22aed82ee919 Author: Lars Wendler <polynomial-c@gentoo.org> AuthorDate: 2019-03-07 22:31:19 +0000 Commit: Lars Wendler <polynomial-c@gentoo.org> CommitDate: 2019-03-07 22:31:19 +0000 app-admin/keepassxc: Revbump to depend on x11-misc/xsel Closes: https://bugs.gentoo.org/667092 Package-Manager: Portage-2.3.62, Repoman-2.3.12 Signed-off-by: Lars Wendler <polynomial-c@gentoo.org> ...ssxc-2.3.4.ebuild => keepassxc-2.3.4-r1.ebuild} | 23 +++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) If it matters this late, in KDE Plasma copy/paste from Keepassxc worked just fine without xsel. Not everyone uses KDE ... That was my point. Maybe xsel should be a dependency of the actual WM/DE with the issue. KeepassXC has no problem here. Yes I see your point, but almost impossible to solve from a packaging system point of view , you can have multiple VM installed but only use 1 . As I pointed out the problem is in Keepassxc not giving errors or solutions to or having good doc. Xsel is a good solution to this , not the best maybe, but the package it's self is a good part of the problem as always. |
