Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 666944

Summary: repoman should report error for uses of ${ROOT}, ${EROOT}, ${D}, ${ED} followed by alphanumeric character in EAPI >=7
Product: Portage Development Reporter: Arfrever Frehtes Taifersar Arahesis <arfrever.fta>
Component: RepomanAssignee: Portage team <dev-portage>
Status: RESOLVED WONTFIX    
Severity: normal CC: leho
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
Package list:
Runtime testing required: ---

Description Arfrever Frehtes Taifersar Arahesis 2018-09-24 04:46:07 UTC
repoman should report error (not just warning) for uses of ${ROOT}, ${EROOT}, ${D}, ${ED} followed by alphanumeric character in EAPI >=7.

The check should not be for these variables followed by [^/] since things like ${D}$(function_returning_path_beginning_with_slash} are valid.


There have been some ebuilds incompletely converted to EAPI >=7.
E.g. bug #666942:
$ grep -E '\${(ROOT|EROOT|D|ED)}[[:alnum:]]' net-mail/mailbase/mailbase-1.4.ebuild
        einfo  "Fixing ${ROOT}var/spool/mail/ permissions"
        chown root:mail "${ROOT}var/spool/mail/"
        chmod 03775 "${ROOT}var/spool/mail/"
Comment 1 Leho Kraav (:macmaN @lkraav) 2018-11-16 23:00:12 UTC
Yes, user.eclass also has problems.

Same for fonts.eclass https://bugs.gentoo.org/show_bug.cgi?id=666635
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-12 03:18:28 UTC
repoman support has been removed per bug 835013.

Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist.