Bug 666934

Summary:	net-misc/rsync: allow using system zlib instead of bundled
Product:	Gentoo Linux	Reporter:	Ian Leonard <antonlacon>
Component:	Current packages	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bertrand, dev-portage, esigra, herrtimson
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/9963 https://bugs.gentoo.org/show_bug.cgi?id=728850
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	251464

Description Ian Leonard 2018-09-24 00:03:15 UTC

Rsync allows building against its bundled zlib or the system zlib via the --with(out)-included-zlib flag to configure. This hasn't been done previously as rsync has a customized zlib bundled to aid in its stream compression. However, since rsync-3.1.1, it has been able to use the bundled zlib (by way of --old-compress) or system zlib (by way of --new-compress) to allow syncing with rsyncd that was built with the opposite zlib choice of the client.

When using system zlib, PORTAGE_RSYNC_EXTRA_OPTS should include "--new-compress" to allow syncing against gentoo's rsync servers. Otherwise, emerge --sync will fail.

Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev

2018-09-24 21:30:18 UTC

Thank you for your contribution.
The base-system team is currently discussing the potential negative influence on our portage rsync mirrors.
Once we have come to a positive conclusion we might apply this change.

Comment 2 Patrick McLean gentoo-dev

2018-09-25 01:37:40 UTC

Adding the portage team to the CC list

Comment 3 Mike Gilbert gentoo-dev

2018-09-25 15:29:18 UTC

Given the incompatibility system zlib would cause, I would suggest disabling it by default for a lengthy period.

Maybe we could enable system zlib by default several years after new compression becomes the default option in rsync.

Comment 4 Larry the Git Cow gentoo-dev

2020-06-16 10:15:37 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b2140e1b35fe5a8a1703c199ef5080c786fe4b49

commit b2140e1b35fe5a8a1703c199ef5080c786fe4b49
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2020-06-16 10:15:16 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2020-06-16 10:15:32 +0000

    net-misc/rsync: Bump to version 3.2.0_pre2
    
    Added support for system-zlib
    
    Bug: https://bugs.gentoo.org/666934
    Package-Manager: Portage-2.3.101, Repoman-2.3.22
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 net-misc/rsync/Manifest                |   1 +
 net-misc/rsync/metadata.xml            |   2 +
 net-misc/rsync/rsync-3.2.0_pre2.ebuild | 114 +++++++++++++++++++++++++++++++++
 3 files changed, 117 insertions(+)

Comment 5 Holger Hoffstätte 2023-09-03 20:11:37 UTC

Looks like this can be closed.