| Summary: | net-libs/webkit-gtk-2.20.5 Compile fails with +gstreamer -opengl | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Michael Meier <mmeier1986> |
| Component: | Current packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bruce |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | AMD64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
Build log showing error with +gstreamer and -opengl
Failed Build log with USE="introspection -gstreamer" |
||
|
Description
Michael Meier
2018-09-23 11:09:24 UTC
Might be fixed with 2.22.1; hoping to bump to 2.22.2 soon. Actually, knowing a bit how they use gstreamer, that's unlikely, but there's some sort of build fix with video disabled. Maybe it means introspection doesn't break without gstreamer anymore, and we can decouple that instead. Would look into it as working on the bump. I didn't have the CPU time for checking these things together with the 2.22.2 bump (plus 2.22 has security fixes that we were overdue to add). Feel free to help testing these things with 2.22.2: * Remove "introspection? ( gstreamer )" from REQUIRED_USE and try if USE="introspection -gstreamer" still fails to build * Try if USE="gstreamer -opengl -gles2" still fails to build as per this bug report Created attachment 550276 [details]
Failed Build log with USE="introspection -gstreamer"
Hello Mart, I've tried the webkit-gtk-2.22.2.ebuild with the same aforementioned useflags, namely "+gstreamer -opengl -gles2" and get the exact same error. I've also tried the "introspection -gstreamer" combination, and it lead to the build error you see in the "Faild Build log with USE="introspection -gstreamer"" attachment. For what it's worth, I've also tried the gstreamer without opengl with Clang instead of GCC, and got the same error. (In reply to Michael Meier from comment #5) > I've tried the webkit-gtk-2.22.2.ebuild with the same aforementioned > useflags, namely "+gstreamer -opengl -gles2" and get the exact same error. > > I've also tried the "introspection -gstreamer" combination, and it lead to > the build error you see in the "Faild Build log with USE="introspection > -gstreamer"" attachment. That's an issue in the older version with USE="-opengl -gles2", which without this failure would simply make all consumers of webkit-gtk fail link instead. All should be good with 2.22.5 then, please open a new bug if not. Please note that building without USE=opengl (or USE=gles2 for some embedded use cases) is NOT suggested whatsoever. You lose async scrolling and more, which will make things feel unnecessarily slower. Even the embedded use cases WebKitWPE library hard requires GL (full opengl or gles2), just webkit-gtk remains to support building without GL for some very very specific embedded cases where the platform really doesn't have any GL whatsoever; I am 99.99% sure that's not the case for you. For avoiding GL on the web, you can disable USE=webgl instead, but USE=opengl itself affects the library and its performance and apparent smoothness directly as well. Maybe a bit late, but I've got the same build error on 2.22.4, worked around it by enabling +opengl.
When emerging 2.22.5 with -opengl again I get a different build error, which goes away when enabling +opengl.
This was the relevant part of the build log:
In file included from /var/tmp/portage/net-libs/webkit-gtk-2.22.5/work/webkitgtk-2.22.5/Source/WebCore/platform/glib/EventHandlerGLib.cpp:38:0:
/var/tmp/portage/net-libs/webkit-gtk-2.22.5/work/webkitgtk-2.22.5/Source/WebCore/platform/PlatformWheelEvent.h:216:60: error: no 'bool WebCore::PlatformWheelEvent::isEndOfNonMomentumScroll() const' member function declared in class 'WebCore::PlatformWheelEvent'
inline bool PlatformWheelEvent::isEndOfNonMomentumScroll() const
^~~~~
/var/tmp/portage/net-libs/webkit-gtk-2.22.5/work/webkitgtk-2.22.5/Source/WebCore/platform/PlatformWheelEvent.h:221:67: error: no 'bool WebCore::PlatformWheelEvent::isTransitioningToMomentumScroll() const' member function declared in class 'WebCore::PlatformWheelEvent'
inline bool PlatformWheelEvent::isTransitioningToMomentumScroll() const
and these are my USE flags: -egl -geolocation -opengl -webgl -jit -libnotify
Does this warrant a different/new bug?
(In reply to Simon from comment #7) > In file included from > /var/tmp/portage/net-libs/webkit-gtk-2.22.5/work/webkitgtk-2.22.5/Source/ > WebCore/platform/glib/EventHandlerGLib.cpp:38:0: > /var/tmp/portage/net-libs/webkit-gtk-2.22.5/work/webkitgtk-2.22.5/Source/ > WebCore/platform/PlatformWheelEvent.h:216:60: error: no 'bool > WebCore::PlatformWheelEvent::isEndOfNonMomentumScroll() const' member > function declared in class 'WebCore::PlatformWheelEvent' > inline bool PlatformWheelEvent::isEndOfNonMomentumScroll() const > ^~~~~ > /var/tmp/portage/net-libs/webkit-gtk-2.22.5/work/webkitgtk-2.22.5/Source/ > WebCore/platform/PlatformWheelEvent.h:221:67: error: no 'bool > WebCore::PlatformWheelEvent::isTransitioningToMomentumScroll() const' member > function declared in class 'WebCore::PlatformWheelEvent' > inline bool PlatformWheelEvent::isTransitioningToMomentumScroll() const > > and these are my USE flags: -egl -geolocation -opengl -webgl -jit -libnotify > > Does this warrant a different/new bug? Yes - upstream mainly. For downstream I'm inclined to remove the choice completely, as almost no-one should be disabling opengl, unless building something specific (for which you'd otherwise use OpenEmbedded or something like that) - yet they do, despite the strong warnings I added, as evidenced here... Upstream bug report for this for 2.22.5 is https://bugs.webkit.org/show_bug.cgi?id=193380 The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=423de9362ed2b23efd5129e22b5bf0e13b2648b8 commit 423de9362ed2b23efd5129e22b5bf0e13b2648b8 Author: Mart Raudsepp <leio@gentoo.org> AuthorDate: 2019-01-17 19:33:50 +0000 Commit: Mart Raudsepp <leio@gentoo.org> CommitDate: 2019-01-17 19:35:42 +0000 net-libs/webkit-gtk: require GL non-GL builds are only meant for some rare use case needs in the embedded world. But they are still broken a bit, so just disallow them for now again. Saves time for those that are for some reason still trying to disable GL fully. Bug: https://bugs.gentoo.org/666806 Package-Manager: Portage-2.3.52, Repoman-2.3.12 Signed-off-by: Mart Raudsepp <leio@gentoo.org> net-libs/webkit-gtk/webkit-gtk-2.22.5.ebuild | 2 ++ 1 file changed, 2 insertions(+) |
