Bug 66605

Summary:	Amule crypto++ things
Product:	Gentoo Linux	Reporter:	Andreas Eriksson <andreas>
Component:	[OLD] Unspecified	Assignee:	Gentoo wxWidgets project <wxwidgets>
Status:	RESOLVED FIXED
Severity:	normal	CC:	flash3001, ghepeu, jlp.bugs, milton.yates
Priority:	High
Version:	unspecified
Hardware:	All
OS:	All
URL:	http://www.amule.org
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Removes P4 specific optimizations. Removes P4 specific optimizations.

Description Andreas Eriksson 2004-10-06 23:29:12 UTC

amule 2.0.0-rc6 (and later) includes its own slimmed version of crypto++.

it has the same bug as those:

http://bugs.gentoo.org/show_bug.cgi?id=63922
http://bugs.gentoo.org/show_bug.cgi?id=64646

the fix is to add -mno-sse2 to CFLAGS.

but shouldn't we disable the internal version of crypto++ and make it use crypto++ from portage?

Comment 1 Mikkel Schubert 2004-10-17 05:09:44 UTC

Created attachment 42026 [details, diff]
Removes P4 specific optimizations.

Yes, the P4 optimizations have caused quite some problems, and we have removed
those specific optimizations from the source, so it shouldn't be a problem when
rc7 is released. I've attached the patch I used, in case you are interested.

Comment 2 Mikkel Schubert 2004-10-17 09:22:30 UTC

Created attachment 42035 [details, diff]
Removes P4 specific optimizations.

Hm, sorry, I accidentally posted (and committed =/) the wrong diff, which
removed _all_ P4 optimizations rather than just SSE2 optimizations. I've
uploaded the corrected patch.

Comment 3 Prakash Punnoor 2004-10-21 23:23:12 UTC

While we're at it, why don't we just disable using of embedded crypto++ and use the global one by specifying --disable-embedded_crypto to amule?

Comment 4 Jon Hood (RETIRED) gentoo-dev

2004-10-22 10:39:16 UTC

*** Bug 65413 has been marked as a duplicate of this bug. ***

Comment 5 Marcin Kurek 2005-03-24 10:26:30 UTC

-mno-sse2 is not recognized for archs diffrent than x86 and makes crypto++ to fail compilaton for example on PowerPC. It should be filtered only for platforms that supports this switch.

Comment 6 Marcin Kryczek (RETIRED) gentoo-dev

2005-09-18 05:26:15 UTC

amule-2.0.3-r1 uses external crypto++. thanks for reporting

Comment 7 Enrico Horn 2005-09-18 10:43:10 UTC

But there seems to be no dependency to crypto++!

Comment 8 Giacomo Perale 2005-09-18 11:38:50 UTC

why use the unneeded external crypto++?

Comment 9 Milton YATES 2005-10-07 20:14:03 UTC

hummm, :/
I still have this crypto++ problem with amule-2.0.3.ebuild (only "stable"
version on amd64).
One can find in that ebuild an econf specifying: --disable-embedded-crypto
no wonder he then asks for the external crypto++ lib.

Either remove this econf option, or add a dependency, or talk to me please :)