Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 665928

Summary: media-tv/mythtv: Validate DEPEND on virtual/mysql
Product: Gentoo Linux Reporter: Brian Evans (RETIRED) <grknight>
Component: Current packagesAssignee: Wilson M. Michaels <thebitpit>
Status: RESOLVED FIXED    
Severity: normal CC: proxy-maint
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/13024
https://github.com/gentoo/gentoo/pull/13027
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 763480    
Attachments: mythtv-29.1.ebuild without mysql dependency

Description Brian Evans (RETIRED) gentoo-dev 2018-09-12 17:31:46 UTC
THIS IS A MASS FILING TO ALL PACKAGE WITH A DEPEND ON virtual/mysql

As was announced on the gentoo-dev-announce mailing list[1],
virtual/mysql is no longer viable to depend on providing the client libraries
or the mysql_config tool.

Most uses of DEPEND="virtual/mysql" (or conditionals based upon it) will not
work in the future.

If this package (optionally) depends on libmysqlclient.so* or mysql_config for
building, you will need to have dev-db/mysql-connector-c as the DEPEND/RDEPEND.

If this package (optionally) depends on libmariadb.so* or mariadb_config for
building, you will need to have dev-db/mariadb-connector-c as the
DEPEND/RDEPEND.

If this package requires the server running locally, virtual/mysql is
acceptible for RDEPEND and only in DEPEND when tests demand it.

The rare exception when server only files are required at build time should you
keep a compatible server listed.

After 60 days, roughly mid-October 2018, remaining packages will be forcefully
changed to mysql-connector-c with little or no testing. The server packages
will drop their compatibility DEPEND shortly after.

[1] https://archives.gentoo.org/gentoo-dev-announce/message/618f39bce863911d8955ee9f83636ca4
Comment 1 Tom Dexter 2019-01-01 16:27:18 UTC
I know that nobody's currently maintaining this. Here's what I'd suggest for addressing this one, and I'll attach a modified version of the existing 29.1 ebuild:

1. Remove the virtual/mysql dependency completely. As far as mysql connectivity (the client libraries) is concerned, the dependencies of other packages like dev-qt/qtsql:5[mysql], dev-perl/DBD-mysql, and dev-python/mysql-python will address that.

2. Make the actions in pkg_config() conditional on the existence of the /usr/bin/mysql client program.

Given that the server USE flag is being removed from mysql, this is probably the only solution that won't require an unnecessary full mysql server install on a frontend only system.

It's already on the user to install either mysql or mariadb on the backend, so I'd say this makes sense.

Tom
Comment 2 Tom Dexter 2019-01-01 16:28:52 UTC
Created attachment 559394 [details]
mythtv-29.1.ebuild without mysql dependency
Comment 3 Larry the Git Cow gentoo-dev 2019-10-09 03:07:50 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=82946d56594d70ff52abbe1b8dda04d3b304e3a1

commit 82946d56594d70ff52abbe1b8dda04d3b304e3a1
Author:     Wilson Michaels <thebitpit@earthlink.net>
AuthorDate: 2019-10-07 17:34:53 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2019-10-09 03:07:22 +0000

    media-tv/mythtv: revision bump mythtv-30.0_p20190808-r1.ebuild
    
    Bug: https://bugs.gentoo.org/665928
    Closes: https://bugs.gentoo.org/695468
    Closes: https://bugs.gentoo.org/695688
    Closes: https://bugs.gentoo.org/695466
    Package-Manager: Portage-2.3.76, Repoman-2.3.16
    Signed-off-by: Wilson Michaels <thebitpit@earthlink.net>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-tv/mythtv/mythtv-30.0_p20190808-r1.ebuild | 416 ++++++++++++++++++++++++
 1 file changed, 416 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e7850cb377af1eed64127eb0c9b3838bbcc57fe0

commit e7850cb377af1eed64127eb0c9b3838bbcc57fe0
Author:     Wilson Michaels <thebitpit@earthlink.net>
AuthorDate: 2019-10-07 17:15:28 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2019-10-09 03:07:17 +0000

    media-tv/mythtv: revision bump mythtv-29.1-r2
    
    Bug: https://bugs.gentoo.org/665928
    Closes: https://bugs.gentoo.org/693648
    Closes: https://bugs.gentoo.org/695684
    Package-Manager: Portage-2.3.76, Repoman-2.3.16
    Signed-off-by: Wilson Michaels <thebitpit@earthlink.net>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-tv/mythtv/metadata.xml          |   3 +-
 media-tv/mythtv/mythtv-29.1-r2.ebuild | 371 ++++++++++++++++++++++++++++++++++
 2 files changed, 373 insertions(+), 1 deletion(-)
Comment 4 Wilson M. Michaels 2019-10-09 14:20:14 UTC
Mythtv depends on a mysql database running somewhere on the LAN. That is well documented my mythtv setup. Mythtv does not require that mysql be built on the same system it is installed on so the dependency is removed.