Bug 665338

Summary:	net-misc/networkmanager - libnm-glib removal
Product:	Gentoo Linux	Reporter:	Mart Raudsepp <leio>
Component:	Current packages	Assignee:	Gentoo Linux Gnome Desktop Team <gnome>
Status:	RESOLVED FIXED
Severity:	normal	CC:	gentoo, ivan, joakim.tjernlund, marduk
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/14365 https://github.com/gentoo/gentoo/pull/14676
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:	712234
Bug Blocks:

Description Mart Raudsepp gentoo-dev

2018-09-06 07:25:57 UTC

Note from 1.12 release NEWS:

* The libnm-glib library, deprecated in favor of libnm since NetworkManager 1.0,
  is now not built by default. While it can still be enabled, the distributions
  should have a good plan for removing it if they need to keep shipping it at
  this point.

This bug is sort of a tracker for this, to not forget. Here I still have it used by geoclue:0, tracker-1.12.4, gnome-shell-3.24.3, nm-applet-1.18.6, networkmanager-openvpn-1.8.4, networkmanager-vpnc-1.2.6 and networkmanager-1.10.10. Maybe some or all of that goes away after rebuilding against NM-1.12? But that's not a clean removal in that case - to be seen as I rebuild and upgrade things. Meanwhile this bug is to not forget the fact that we need to work on removing libnm-glib from gentoo after I'm adding 1.12 with the build of it still always enabled.

Comment 1 Mart Raudsepp gentoo-dev

2019-02-11 19:12:30 UTC

nm-applet upstream now does not build libnm-gtk by default, but I had to keep building it still via configure flag (e.g. various plugins require it, but some or all can use that optionally too, didn't investigate much).
libnm-gtk from nm-applet is the primary consumer of libnm-glib that is left probbaly; so we first need to get rid of that in nm-applet and then we can start really thinking about not doing libnm-glib in networkmanager package

Comment 2 Matt Turner gentoo-dev

2019-10-19 19:35:27 UTC

(In reply to Mart Raudsepp from comment #1)
> nm-applet upstream now does not build libnm-gtk by default, but I had to
> keep building it still via configure flag (e.g. various plugins require it,
> but some or all can use that optionally too, didn't investigate much).
> libnm-gtk from nm-applet is the primary consumer of libnm-glib that is left
> probbaly; so we first need to get rid of that in nm-applet and then we can
> start really thinking about not doing libnm-glib in networkmanager package

FWIW, gnome-extra/nm-applet is the only thing on my system that links with libnm-glib.so.

Comment 3 Joakim Tjernlund 2020-02-26 12:08:34 UTC

Is external libnma also needed now?

Comment 4 Joakim Tjernlund 2020-02-26 12:11:28 UTC

(In reply to Joakim Tjernlund from comment #3)
> Is external libnma also needed now?

There is an PR at
https://gitlab.gnome.org/GNOME/network-manager-applet/-/merge_requests/73

Comment 5 Larry the Git Cow gentoo-dev

2020-03-11 21:30:58 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0dd37329676dcdad19fa6a3230f4231814e49047

commit 0dd37329676dcdad19fa6a3230f4231814e49047
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2020-02-16 17:32:18 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2020-03-11 21:30:36 +0000

    net-misc/networkmanager: bump to 1.22.8
    
    [mattst88]: Fix s/epbf/ebpf/ typo
                Keep keywords, but add to package.mask
                Bump 1.22.6 -> 1.22.8
    
    Bug: https://bugs.gentoo.org/665338
    Closes: https://bugs.gentoo.org/702898
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 net-misc/networkmanager/Manifest                   |   1 +
 net-misc/networkmanager/metadata.xml               |   4 +
 .../networkmanager/networkmanager-1.22.8.ebuild    | 329 +++++++++++++++++++++
 profiles/package.mask                              |   4 +
 4 files changed, 338 insertions(+)

Comment 6 Albert W. Hopkins 2020-03-12 02:03:01 UTC

With this change net-vpn/networkmanager-openvpn-1.8.10 is wanting to get rebuilt in @preserved-rebuild, but when I try to rebuild it I get:

```
...
checking pkg-config is at least version 0.9.0... yes
checking for GLIB... yes
checking for GTK... yes
checking for LIBNMA... yes
checking for LIBSECRET... yes
checking for LIBNM_GTK... no
configure: error: Package requirements (libnm-gtk >= 1.7.0) were not met:

No package 'libnm-gtk' found
```

Comment 7 Matt Turner gentoo-dev

2020-03-12 05:57:01 UTC

(In reply to Albert W. Hopkins from comment #6)
> With this change net-vpn/networkmanager-openvpn-1.8.10 is wanting to get
> rebuilt in @preserved-rebuild, but when I try to rebuild it I get:
> 
> ```
> ...
> checking pkg-config is at least version 0.9.0... yes
> checking for GLIB... yes
> checking for GTK... yes
> checking for LIBNMA... yes
> checking for LIBSECRET... yes
> checking for LIBNM_GTK... no
> configure: error: Package requirements (libnm-gtk >= 1.7.0) were not met:
> 
> No package 'libnm-gtk' found
> ```

Thank you.

Please open new bugs for each package you find that is affected and make it block this one.

Comment 8 Joakim Tjernlund 2020-03-12 08:44:08 UTC

(In reply to Albert W. Hopkins from comment #6)
> With this change net-vpn/networkmanager-openvpn-1.8.10 is wanting to get
> rebuilt in @preserved-rebuild, but when I try to rebuild it I get:
> 
> ```
> ...
> checking pkg-config is at least version 0.9.0... yes
> checking for GLIB... yes
> checking for GTK... yes
> checking for LIBNMA... yes
> checking for LIBSECRET... yes
> checking for LIBNM_GTK... no
> configure: error: Package requirements (libnm-gtk >= 1.7.0) were not met:
> 
> No package 'libnm-gtk' found
> ```

does it work if you do USE="-gtk" ?

Comment 9 Albert W. Hopkins 2020-03-12 13:07:45 UTC

Created bug #712234

Comment 10 Mart Raudsepp gentoo-dev

2020-06-07 22:01:13 UTC

I think we can consider this issue resolved now