| Summary: | sys-devel/llvm: Add Julia patchset to llvm-6 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Matthias Maier <tamiko> |
| Component: | Current packages | Assignee: | LLVM support project <llvm> |
| Status: | RESOLVED OBSOLETE | ||
| Severity: | normal | CC: | dschridde+gentoobugs, herrtimson, jeffrey, koz.ross, lssndrbarbieri, mgorny, O01eg |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/10692 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
|
Description
Matthias Maier
2018-09-03 22:32:21 UTC
Three of these patches have been merged upstream; one is still being reviewed: https://reviews.llvm.org/rL338073 https://reviews.llvm.org/rL323946 https://reviews.llvm.org/rL323946 https://reviews.llvm.org/D50010 https://reviews.llvm.org/D50167 Please let us know when they're all merged upstream. Those are certainly intrusive changes, and I'm not going to potentially break clang for this. If this is likely to be a recurring problem once in a while, please add option to install bundled patched LLVM. I'm probably not the only one that would much rather have to compile LLVM twice (or pull it in binary, don't really care) than have an outdated Julia. Julia's upstream devs even strongly recommend bundling a separate LLVM specifically for Julia as part of its package. Quoting their README.md: "The most complicated dependency is LLVM, for which we require version 3.9 with some additional patches from upstream (LLVM is not backward compatible). For packaging Julia, we recommend either: - bundling a Julia-only LLVM library inside the Julia package, or - adding the patches to the LLVM 3.9 package of the distribution." As far as I understand, this is also what their build from source does. Was the patch we are waiting for merged upstreadm in llvm-8 ? (In reply to cryptopsy from comment #5) > Was the patch we are waiting for merged upstreadm in llvm-8 ? No. It's the usual case of somebody forking LLVM, making incompatible changes, making a lot of code relying on them, and then being surprised upstream doesn't like them. (In reply to Michał Górny from comment #6) > > No. It's the usual case of somebody forking LLVM, making incompatible > changes, making a lot of code relying on them, and then being surprised > upstream doesn't like them. No it is not. The fact that most of these patches are merged upstream and every single patch *fixes a regression* contradicts your argument here. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c545f629a77bf34ddd9f2d357502f88d8064ed9d commit c545f629a77bf34ddd9f2d357502f88d8064ed9d Author: Matthias Maier <tamiko@gentoo.org> AuthorDate: 2019-01-07 21:04:48 +0000 Commit: Matthias Maier <tamiko@gentoo.org> CommitDate: 2019-01-07 21:35:31 +0000 dev-lang/julia: version bump to 1.1.0-rc1 * give up and bundle llvm-6 Bug: https://bugs.gentoo.org/665192 Package-Manager: Portage-2.3.54, Repoman-2.3.12 Signed-off-by: Matthias Maier <tamiko@gentoo.org> dev-lang/julia/Manifest | 3 + .../julia/files/julia-1.1.0-fix_build_system.patch | 53 ++++++ dev-lang/julia/julia-1.1.0_rc1.ebuild | 197 +++++++++++++++++++++ 3 files changed, 253 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b3f5076cbb154f273ea52417f3a6542dc964cf49 commit b3f5076cbb154f273ea52417f3a6542dc964cf49 Author: Jeffrey Lin <jeffrey@icurse.nl> AuthorDate: 2018-12-24 18:05:27 +0000 Commit: Matthias Maier <tamiko@gentoo.org> CommitDate: 2019-01-07 21:35:26 +0000 dev-lang/julia-bin: new package Bug: https://bugs.gentoo.org/665192 Closes: https://github.com/gentoo/gentoo/pull/10692 Package-Manager: Portage-2.3.52, Repoman-2.3.12 Signed-off-by: Jeffrey Lin <jeffrey@icurse.nl> Signed-off-by: Matthias Maier <tamiko@gentoo.org> dev-lang/julia-bin/Manifest | 5 ++++ dev-lang/julia-bin/julia-bin-1.0.3.ebuild | 43 +++++++++++++++++++++++++++++++ dev-lang/julia-bin/metadata.xml | 31 ++++++++++++++++++++++ 3 files changed, 79 insertions(+) Actually, thinking about it - it would still be best if we could just apply the 4 patches in question. For reference, Debian did the same: https://sources.debian.org/patches/llvm-toolchain-6.0/1:6.0.1-6/ |
