| Summary: | dev-util/tup-0.7.7 : [TEST] * (no error message) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
| Component: | Current packages | Assignee: | Andriy Utkin (RETIRED) <andrey_utkin> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Keywords: | TESTFAILURE |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
emerge-info.txt
dev-util:tup-0.7.7:20180828-114836.log emerge-history.txt environment etc.portage.tbz2 |
||
|
Description
Toralf Förster
2018-08-28 15:58:07 UTC
Created attachment 545324 [details]
emerge-info.txt
Created attachment 545326 [details]
dev-util:tup-0.7.7:20180828-114836.log
Created attachment 545328 [details]
emerge-history.txt
Created attachment 545330 [details]
environment
Created attachment 545332 [details]
etc.portage.tbz2
Thanks for the report. I noticed that tup's dependency on FUSE is tricky for test phase. But tup inherently uses FUSE to gain the benefits, so if tinderbox doesn't have FUSE in the running kernel, most probably all we can do is to give a clear message to the user that tests won't work. I think what needs to be done is * REQUIRED_USE=kernel_linux * pkg_postinst() to emit einfo about necessary kernel config options * src_test() should first check for /dev/fuse and fail early if it's not available. Maybe there's a smarter option? Need to think about it. You can use something like this ``` inherit linux-info [...] CONFIG_CHECK='FUSE_FS' ``` It will run `linux-info_pkg_setup` and check that the options is set in the built kernel (which is usually the one running). That should cover pretty much everything you need for tup. If wanted, you can also add the configs needed for namespaces, which won't fail the build but fail the use. (In reply to tharvik from comment #7) > You can use something like this > ``` > inherit linux-info > [...] > CONFIG_CHECK='FUSE_FS' > ``` > It will run `linux-info_pkg_setup` and check that the options is set in the > built kernel (which is usually the one running). > That should cover pretty much everything you need for tup. If wanted, you > can also add the configs needed for namespaces, which won't fail the build > but fail the use. Thanks, that's useful! (I hope I'll get to fixing this at some point...) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=066dc8d64640f78bb7d93a0a489d61ce5b1efef9 commit 066dc8d64640f78bb7d93a0a489d61ce5b1efef9 Author: Andrey Utkin <andrey_utkin@gentoo.org> AuthorDate: 2018-12-02 02:02:56 +0000 Commit: Andrey Utkin <andrey_utkin@gentoo.org> CommitDate: 2018-12-02 02:46:23 +0000 dev-util/tup: fail src_test if no /dev/fuse It fails anyway (see bug 664768). Provide user with clear error message. No revbump for 0.7.7 as the change doesn't affect successful installations. Bug: https://bugs.gentoo.org/664768 Package-Manager: Portage-2.3.49, Repoman-2.3.12 Signed-off-by: Andrey Utkin <andrey_utkin@gentoo.org> dev-util/tup/tup-0.7.7.ebuild | 1 + dev-util/tup/tup-9999.ebuild | 1 + 2 files changed, 2 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8753de7a2413c60609ca0b99616a8e19da29d4f6 commit 8753de7a2413c60609ca0b99616a8e19da29d4f6 Author: Andrey Utkin <andrey_utkin@gentoo.org> AuthorDate: 2018-12-02 01:47:51 +0000 Commit: Andrey Utkin <andrey_utkin@gentoo.org> CommitDate: 2018-12-02 02:46:22 +0000 dev-util/tup: warn if important kernel options are not enabled No revbump for 0.7.7 as the change doesn't affect successful installations. Bug: https://bugs.gentoo.org/664768 Package-Manager: Portage-2.3.49, Repoman-2.3.12 Signed-off-by: Andrey Utkin <andrey_utkin@gentoo.org> dev-util/tup/tup-0.7.7.ebuild | 8 ++++++-- dev-util/tup/tup-9999.ebuild | 8 ++++++-- 2 files changed, 12 insertions(+), 4 deletions(-) Honestly I haven't tested the change with kernel not satisfying the requirements, but I believe the changes pushed are sufficient. Toralf, are you keen on proceeding with testing this package in an environment accomodating its needs? I presume not. But let me know if you run into any other issues if you go for it. |