Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 664634

Summary: games-simulation/simutrans-0.120.2.2 : bauer/.../sparse_tpl.h:60:11: error: binding reference of type koord& to const koord discards qualifiers
Product: Gentoo Linux Reporter: Toralf Förster <toralf>
Component: Current packagesAssignee: Gentoo Games <games>
Status: RESOLVED FIXED    
Severity: normal CC: ansla80, bugs, treecleaner
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: emerge-info.txt
emerge-history.txt
environment
etc.portage.tbz2
games-simulation:simutrans-0.120.2.2:20180826-105645.log
logs.tbz2
Fixes compile error

Description Toralf Förster gentoo-dev 2018-08-26 11:03:43 UTC
                 from bauer/fabrikbauer.cc:17:
bauer/../tpl/sparse_tpl.h: In member function ‘koord& sparse_tpl<T>::get_size() const’:
bauer/../tpl/sparse_tpl.h:60:11: error: binding reference of type ‘koord&’ to ‘const koord’ discards qualifiers
    return size;
           ^~~~
make: *** [common.mk:51: build/default/bauer/fabrikbauer.o] Error 1

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.0-developer_libressl-test_20180819-103958

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-7.3.1
 [2] x86_64-pc-linux-gnu-8.2.0 *

Available Python interpreters, in order of preference:
  [1]   python3.7
  [2]   python3.6
  [3]   python2.7 (fallback)

java-config:
The following VMs are available for generation-2:
*)	IcedTea JDK 3.8.0 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8  system-vm

emerge -qpv games-simulation/simutrans
[ebuild  N    ] games-simulation/simutrans-0.120.2.2 

!!! The following installed packages are masked:
- dev-python/paramiko-2.3.1::gentoo (masked by: package.mask)
/usr/portage/profiles/package.mask:
# Virgil Dupras <vdupras@gentoo.org> (23 Aug 2018)
# Vulnerable and can't be removed yet because of alpha. Bug #664346

For more information, see the MASKED PACKAGES section in the emerge
man page or refer to the Gentoo Handbook.
Comment 1 Toralf Förster gentoo-dev 2018-08-26 11:03:46 UTC
Created attachment 545094 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2018-08-26 11:03:49 UTC
Created attachment 545096 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2018-08-26 11:03:52 UTC
Created attachment 545098 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2018-08-26 11:03:55 UTC
Created attachment 545100 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2018-08-26 11:03:58 UTC
Created attachment 545102 [details]
games-simulation:simutrans-0.120.2.2:20180826-105645.log
Comment 6 Toralf Förster gentoo-dev 2018-08-26 11:04:00 UTC
Created attachment 545104 [details]
logs.tbz2
Comment 7 Christopher Head 2019-11-11 17:26:20 UTC
Created attachment 595790 [details, diff]
Fixes compile error

The attached patch fixes the compile error (honestly, not sure how the thing ever compiled in the first place). There’s also a newer version available, which might fix the problem too.
Comment 8 Agostino Sarubbo gentoo-dev 2020-10-20 14:03:23 UTC
Dear treecleaner@:

I'm still able to reproduce this issue right now.

Since it has not been fixed for a long time, I'd suggest to evaluate if it is the case to remove this package from the tree. Thanks
Comment 9 Christopher Head 2020-10-20 15:20:33 UTC
(In reply to Agostino Sarubbo from comment #8)
> Dear treecleaner@:
> 
> I'm still able to reproduce this issue right now.
> 
> Since it has not been fixed for a long time, I'd suggest to evaluate if it
> is the case to remove this package from the tree. Thanks

Personally I hope it doesn’t get removed. Actually I had forgotten about this bug; I will see about a PR (either to add this patch or to just update to the newer version), since PRs seem to occasionally get merged while bugs often (as seen here) get completely ignored. Hopefully the cleaners can be held at bay long enough for the PR to be merged.
Comment 10 Christopher Head 2020-10-20 15:22:41 UTC
Oh actually someone else already made one: https://github.com/gentoo/gentoo/pull/15314 AFAICT all review comments have been addressed, but nobody has done anything with it for almost six months.
Comment 11 Larry the Git Cow gentoo-dev 2020-10-23 17:13:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3cd3ac0da3b0b26ee001e014ccec1aa45d131ef6

commit 3cd3ac0da3b0b26ee001e014ccec1aa45d131ef6
Author:     Ronny Gutbrod <gentoo@tastytea.de>
AuthorDate: 2020-04-11 20:56:14 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-10-23 17:07:02 +0000

    games-simulation/simutrans: Version bump 0.122.0.
    
    Also add a Desktop Entry and all the maintained paksets (scenario data) via
    use-flags.
    
    Closes: https://bugs.gentoo.org/668504
    Closes: https://bugs.gentoo.org/636324
    Closes: https://bugs.gentoo.org/664634
    Closes: https://bugs.gentoo.org/724470
    Closes: https://bugs.gentoo.org/739360
    Signed-off-by: Ronny (tastytea) Gutbrod <gentoo@tastytea.de>
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 games-simulation/simutrans/Manifest                |   8 ++
 .../files/simutrans-0.122.0-Fix-Makefile.patch     |  21 ++++
 games-simulation/simutrans/files/simutrans.desktop |   9 ++
 games-simulation/simutrans/metadata.xml            |  14 ++-
 .../simutrans/simutrans-0.122.0.ebuild             | 106 +++++++++++++++++++++
 5 files changed, 156 insertions(+), 2 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fb75467bcf4b8c308ebbc5b9121a6f42d43680d3

commit fb75467bcf4b8c308ebbc5b9121a6f42d43680d3
Author:     Ronny (tastytea) Gutbrod <gentoo@tastytea.de>
AuthorDate: 2020-10-23 14:50:59 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-10-23 17:08:15 +0000

    games-simulation/simutrans: Delete old ebuild.
    
    It doesn't compile since 2018.
    
    Bug: https://bugs.gentoo.org/664634
    Bug: https://bugs.gentoo.org/724470
    Bug: https://bugs.gentoo.org/739360
    
    Signed-off-by: Ronny (tastytea) Gutbrod <gentoo@tastytea.de>
    Closes: https://github.com/gentoo/gentoo/pull/15314
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 games-simulation/simutrans/Manifest                |  3 -
 .../files/simutrans-0.120.2.2-Makefile.patch       | 89 ----------------------
 .../simutrans/simutrans-0.120.2.2.ebuild           | 71 -----------------
 3 files changed, 163 deletions(-)