Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 664512

Summary: net-misc/spice-gtk-0.35: with >=dev-libs/libressl-2.7 breakage
Product: Gentoo Linux Reporter: Tom Li <biergaizi2009>
Component: Current packagesAssignee: Virtualization Team <virtualization>
Status: RESOLVED FIXED    
Severity: normal CC: biergaizi2009, jstein, libressl, pagorman, steils
Priority: Normal Keywords: PATCH, PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/11062
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 651228    
Attachments: LibreSSL 2.7 fix

Description Tom Li 2018-08-24 18:24:46 UTC
libtool: compile:  x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I.. -I/usr/include/pixman-1 -I/usr/include/cacard -I/usr/include/nss -I/usr/include/nspr -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/opus -DG_LOG_DOMAIN=\"Spice\" -I/usr/include/spice-1 -march=native -O2 -pipe -fomit-frame-pointer -Wp,-D_GLIBCXX_ASSERTIONS -fstack-clash-protection -fcf-protection=full -c generated_client_demarshallers.c  -fPIC -DPIC -o .libs/generated_client_demarshallers.o
ssl_verify.c:37:29: error: static declaration of ‘ASN1_STRING_get0_data’ follows non-static declaration
 static const unsigned char *ASN1_STRING_get0_data(const ASN1_STRING *asn1)
                             ^~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/openssl/rsa.h:64,
                 from ssl_verify.h:31,
                 from ssl_verify.c:24:
/usr/include/openssl/asn1.h:788:22: note: previous declaration of ‘ASN1_STRING_get0_data’ was here
 const unsigned char *ASN1_STRING_get0_data(const ASN1_STRING *x);
                      ^~~~~~~~~~~~~~~~~~~~~

It needs the same patch from https://bugs.gentoo.org/655356.
Comment 1 Tom Li 2018-08-24 18:35:06 UTC
Hmmm, the 655356
Comment 2 Tom Li 2018-08-24 18:40:06 UTC
Hmmmm, the patch from 655356 was not enough to fix the problem. Once the patch is applied, more conflicts showed up. Fixes are needed for three separate code snippets.
Comment 3 Tom Li 2018-08-24 18:42:38 UTC
Created attachment 544872 [details, diff]
LibreSSL 2.7 fix

This patch fixes everything.
Comment 4 pagorman 2018-11-03 01:13:52 UTC
*** Bug 669886 has been marked as a duplicate of this bug. ***
Comment 5 Larry the Git Cow gentoo-dev 2019-02-16 17:59:40 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0c57f77f684053bbc14049127f8c537874ad61c1

commit 0c57f77f684053bbc14049127f8c537874ad61c1
Author:     Stefan Strogin <stefan.strogin@gmail.com>
AuthorDate: 2019-02-16 03:38:17 +0000
Commit:     Aaron Bauman <bman@gentoo.org>
CommitDate: 2019-02-16 17:59:30 +0000

    net-misc/spice-gtk: fix build for >=libressl-2.7.0
    
    NB: spice-gtk-0.34-libressl.patch was not used anywhere.
    
    Closes: https://bugs.gentoo.org/664512
    Package-Manager: Portage-2.3.60, Repoman-2.3.12
    Signed-off-by: Stefan Strogin <stefan.strogin@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/11062
    Signed-off-by: Aaron Bauman <bman@gentoo.org>

 ...ibressl.patch => spice-gtk-0.35-libressl.patch} |  25 ++--
 net-misc/spice-gtk/spice-gtk-0.35-r1.ebuild        | 154 +++++++++++++++++++++
 2 files changed, 170 insertions(+), 9 deletions(-)
Comment 6 Arvid Brodin 2019-05-24 20:44:10 UTC
I ran into this today with portage from 2019-05-19 since I'm running stable and the fix is marked ~amd64. Maybe make net-misc/spice-gtk-0.35-r1 stable? (I can confirm that -r1 fixes this build error.)