Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 664270

Summary: media-gfx/splashutils-1.5.4.4-r8 segmentation fault (patch)
Product: Gentoo Linux Reporter: Vasiliy <6vasia>
Component: Current packagesAssignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status: RESOLVED OBSOLETE    
Severity: normal CC: jstein, treecleaner
Priority: Normal Keywords: PATCH, PMASKED
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard: Pending removal: 2018-11-21
Package list:
Runtime testing required: ---
Attachments: image buffer size patch

Description Vasiliy 2018-08-22 15:38:41 UTC
Created attachment 544468 [details, diff]
image buffer size patch

fbcondecor_helper segfaults when loading big png.

This is caused by line 104 in image.c:

        *data = malloc(theme->xres * theme->yres * fbd.bytespp);

where xres, yres and bpp are NOT image, but fbdev parameters.

Patch proposal attached. Fixes SEGV, but 8-bit RGB image is funky on 16bpp FB.
Comment 1 Vasiliy 2018-08-23 12:29:55 UTC
RGBA images look ok.

There is code to add alpha, but its under #ifndef TARGET_KERNEL.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-11-28 13:20:05 UTC
Package removed.