Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 66368

Summary: enhancements for ati control panel (ati-drivers-extra, fglrx_panel)
Product: Gentoo Linux Reporter: Ernst Sjöstrand <ernstp>
Component: [OLD] UnspecifiedAssignee: Luca Barbato <lu_zero>
Status: RESOLVED FIXED    
Severity: enhancement CC: mtippett
Priority: High    
Version: unspecified   
Hardware: x86   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Rev. bumped ebuild.
dont-make-it-ugly.patch
fd.org-desktop-loc.patch
makefile-conventions.patch
new-desktop-file.patch
sliders.patch
cpp_cast.good.patch
effcpp.patch
gamma_fix.patch
gcc3.4_adjustpage_crash.patch
gcc3.4_adjustpage_crash.patch

Description Ernst Sjöstrand 2004-10-04 16:56:06 UTC
Here are a bunch of patches I made for ati's control panel.
The patches include a .desktop for fd.o desktop locations, a cosmetic one, 
a really nice one (sliders.patch) and some other stuff.

Reproducible: Always
Steps to Reproduce:
Comment 1 Ernst Sjöstrand 2004-10-04 16:57:39 UTC
Created attachment 41105 [details]
Rev. bumped ebuild.
Comment 2 Ernst Sjöstrand 2004-10-04 16:59:03 UTC
Created attachment 41106 [details, diff]
dont-make-it-ugly.patch
Comment 3 Ernst Sjöstrand 2004-10-04 16:59:27 UTC
Created attachment 41107 [details, diff]
fd.org-desktop-loc.patch
Comment 4 Ernst Sjöstrand 2004-10-04 16:59:53 UTC
Created attachment 41108 [details, diff]
makefile-conventions.patch
Comment 5 Ernst Sjöstrand 2004-10-04 17:00:29 UTC
Created attachment 41109 [details, diff]
new-desktop-file.patch
Comment 6 Ernst Sjöstrand 2004-10-04 17:00:47 UTC
Created attachment 41110 [details, diff]
sliders.patch
Comment 7 Luca Barbato gentoo-dev 2004-10-04 22:44:42 UTC
Thanks for your improvement to the control panel, I hope to find the time to test it during the day.
Comment 8 Ernst Sjöstrand 2004-10-11 15:53:19 UTC
Yo, how's it going?
Comment 9 Ernst Sjöstrand 2004-10-16 08:43:26 UTC
Tested it? Things happening behind the scene?
Comment 10 Luca Barbato gentoo-dev 2004-10-18 08:11:48 UTC
Sadly got busy with some higher priority tasks and haven't find the time to do it yet. (I know I'm disappointing you but sadly I got ill for a week and now I have to keep up with university and other real life issues)
Comment 11 Luca Barbato gentoo-dev 2004-10-19 23:51:31 UTC
eventually I found the time to test it a bit, will be in portage within 30 min
Comment 12 Ernst Sjöstrand 2004-10-20 04:48:08 UTC
Right, we need something like:
                insinto /usr/share/applications/
                doins ${FILESDIR}/fireglcontrol.desktop
instead of:
                cp ${FILESDIR}/fireglcontrol.desktop ${WORKDIR}/extra/fglrx_panel

because make install is pretty broken and not used in the ebuild.

As it is now, the desktop file is not installed.
Comment 13 Luca Barbato gentoo-dev 2004-10-21 00:53:37 UTC
fix added, thanks
Comment 14 Luca Barbato gentoo-dev 2004-10-21 00:54:05 UTC
(eventually closing the bug)
Comment 15 Robert Wohlrab 2004-10-22 08:10:41 UTC
Created attachment 42418 [details, diff]
cpp_cast.good.patch

cast cleanup (c casts to c++ casts) for fglrx_panel_sources (not really usefull
for users, but for developers)
Comment 16 Robert Wohlrab 2004-10-22 08:13:25 UTC
Created attachment 42419 [details, diff]
effcpp.patch

Changes to get the sourcecode in a more "Effective C++" way (not really useful
for users, but for developers)
Comment 17 Robert Wohlrab 2004-10-22 08:15:10 UTC
Created attachment 42420 [details, diff]
gamma_fix.patch

* Removes SIGNAL(sliderMoved(int)) changes from ernstp's sliders patch -> you
can use keyboard and mousewheel again.
* Remove type conversation errors when checking for changes -> no abnormal
slider moving in linked mode
* Specific values (min, max) when the loaded gamma are out of range
* Changed GAMMA_MIN to 0.12 -> the driver seems to interpret lower values as
1.0
Comment 18 Robert Wohlrab 2004-10-22 08:16:29 UTC
Created attachment 42421 [details, diff]
gcc3.4_adjustpage_crash.patch

Fixes following problem with gcc 3.4(.2)

* when i click first on adjustment and then dualscreen, nothing can be seen on
this tab
* when i clicked on adjustment and then click on a button the fireglcontrol
will segfault
Comment 19 Robert Wohlrab 2004-10-22 08:17:44 UTC
More informations can maybe found on http://rage3d.com/board/showthread.php?t=33782848
Comment 20 Robert Wohlrab 2004-10-26 10:36:51 UTC
Created attachment 42644 [details, diff]
gcc3.4_adjustpage_crash.patch

Same as old gcc3.4_adjustpage_crash.patch:

Fixes following problem with gcc 3.4(.2)

* when i click first on adjustment and then dualscreen, nothing can be seen on
this tab
* when i clicked on adjustment and then click on a button the fireglcontrol
will segfault


+ added comment (thx dragondestroyer)