| Summary: | games-util/umodpack Updated ebuild with "can't use a hash as a reference" errors fixed | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | James Jones <gentoo> |
| Component: | Current packages | Assignee: | Gentoo Games <games> |
| Status: | UNCONFIRMED --- | ||
| Severity: | normal | CC: | gentoo, jstein |
| Priority: | Normal | Keywords: | EBUILD, PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 663632 | ||
| Bug Blocks: | |||
| Attachments: |
Updated ebuild
The patch Manifest file for my local repository Manifest file for my local repository Manifest file for my local repository Updated ebuild v2 Manifest file for my local repository Updated ebuild v3 Updated ebuild v4 Manifest file for my local repository |
||
Created attachment 542986 [details, diff]
The patch
The patch to fix the hash-as-a-reference lines
Created attachment 542988 [details]
Manifest file for my local repository
My local manifest, in case it helps.
Thank you for your contribution. I had a short look on the ebuild. Here a few ideas: * Please test the ebuild with repoman full -x https://wiki.gentoo.org/wiki/Repoman * We always try to use the latest EAPI, please bump to EAPI=7 * Please remove obsolete lines * please fix the header. (see /usr/portage/skel.ebuild and https://devmanual.gentoo.org/ebuild-writing/eapi/) * SRC_URI="mirror://gentoo/${MY_P}-allinone.tar.gz" The Gentoo Mirror is no valid Source URI Created attachment 543464 [details]
Manifest file for my local repository
Created attachment 543466 [details]
Manifest file for my local repository
Created attachment 543468 [details] Updated ebuild v2 Thanks for taking a look. I've attempted to address your feedback, but ran into some issues: * EAPI 7 isn't supported by some dependencies, namely perl-module.eclass and its dependency perl-functions.eclass. I created bug https://bugs.gentoo.org/663632 to track that, and attached some updated files there that were good enough to get this package working with EAPI=7. * I wasn't clear which lines were obsolete, nor what was wrong with the header. I compared the file to the skeleton ebuild, but the only difference I could discern was an outdated copyright. I adjusted it to 2018. Created attachment 543470 [details]
Manifest file for my local repository
Created attachment 543472 [details]
Updated ebuild v3
Fix cut/paste error in SRC_URI that dropped use of MY_P var
Could someone recommend how to proceed here? I don't want to let this to stagnate forever. Should I push on the perl eclass updates in bug 663632, or drop the EAPI back down to 6 until the perl eclass is updated to EAPI 7 by someone more knowledgable? Anything else as far as cleanups needed for the small ebuild update in this bug? 6 is fine in the meantime. Thanks for your work on this. Created attachment 545486 [details]
Updated ebuild v4
OK, thanks for the feedback. Attaching the ebuild with EAPI dropped down to 6. Re-tested installing it, and then installing unreal-tournament-goty and unreal-tournament-bonuspacks. Everything looks good.
Created attachment 545488 [details]
Manifest file for my local repository
Attaching updated Manifest
|
Created attachment 542984 [details] Updated ebuild Had to install unreal-tournament-bonuspacks today, and the umodpack extraction step failed because umodpack was using perl hashes as references. I put together a patch and updated the build while I was at it.